Project

General

Profile

Bug #9998

French translation of dartable's GUI

Added by Michel Leblond over 5 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Start date:
06/23/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

It seems to me that all commands in darktable's GUI begin with a lowercase letter.

However in the darkroom view the command add in the panel global color picker is translated as "Ajouter".

It is the same with "Enlever"

Best regards

History

#1 Updated by Pascal Obry over 5 years ago

Indeed, same in English in fact. We do not translate those strings which are from Gtk: GTK_STOCK_ADD.

No sure what to do?

#2 Updated by Pascal Obry over 5 years ago

A solution is to replace the Gtk+ strings by standard strings with proper casing. How about that?

#3 Updated by Michel Leblond over 5 years ago

I think this is a good method. But I do not know how to do that. I am not an expert in GTK programming. Why would it be impossible to do for the add button what is done for other buttons: eg copy, copy all, discard ...?

#4 Updated by Tobias Ellinghaus over 5 years ago

The benefit of having it shown by GTK is that it is automatically translated the same as in other applications and we don't have to mess with icons and such. Just keep that in mind and decide as you want. I am fine with both ways – but also tend to change it.

#5 Updated by Michel Leblond over 5 years ago

There is only a few buttons defined by means of GTK_STOCK. We can see that with the command

grep -r gtk_button_new_from_stock *

which gives:

Fichier binaire build/src/libs/libgeotagging.so concordant
Fichier binaire build/src/libs/libcolorpicker.so concordant
Fichier binaire build/src/libs/CMakeFiles/colorpicker.dir/colorpicker.c.o concordant
Fichier binaire build/src/libs/CMakeFiles/geotagging.dir/geotagging.c.o concordant
src/libs/colorpicker.c: sample->delete_button = gtk_button_new_from_stock(GTK_STOCK_REMOVE);
src/libs/colorpicker.c: data->add_sample_button = gtk_button_new_from_stock(GTK_STOCK_ADD);
src/libs/geotagging.c: GtkWidget *cancel_button = gtk_button_new_from_stock(GTK_STOCK_CANCEL);
src/libs/geotagging.c: GtkWidget *ok_button = gtk_button_new_from_stock(GTK_STOCK_OK);

If this is true it may be worthwhile to make an homogenization effort.

#6 Updated by Pascal Obry over 5 years ago

Ok, see https://github.com/darktable-org/darktable/pull/608 which removes all the stock labels.

Ok to merge?

#7 Updated by Michel Leblond over 5 years ago

I tested the changes and it seems right to me. But line 397 must be changed in
GtkWidget *ok_button = gtk_button_new_with_label(_("ok"));

Ok to merge !

Thank you.

#8 Updated by Pascal Obry over 5 years ago

Sure, the translation will come next. Let's merge.

#9 Updated by Pascal Obry over 5 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Merged and now translated. All this while commuting by train :) How nice mobile phone are those days :)

#10 Updated by Michel Leblond over 5 years ago

Thank you very much ! We are living in a fantastic communication world ! In my youth I lived in a world without phone!

Also available in: Atom PDF

Go to top