Project

General

Profile

Bug #9756

Disk exporter adds XMP data to exif tags after the event intermediate-export-image

Added by RK C about 6 years ago. Updated about 6 years ago.

Status:
Fixed
Priority:
Low
Category:
Lua
Start date:
01/01/2014
Due date:
% Done:

100%

Estimated time:
Affected Version:
1.4
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The disk exporter is adding XMP data to the image after generic part is done adding EXIF tag

In attempting to run exiftool to strip all exif data as part of a lua script handling the event intermediate-export-image, it is discovered that the temporary image available for the script does not have all the exif data in it. Some are added after the event is handled by the script. This defeats the purpose of the script.
Script -> http://pastebin.com/k3DFXXtW (you need exiftool installed to test this; leaves <file>_original as a copy of the original)
Pipeline of events (as I understand) => [Export to disk] -> [Export Image] -> [Event intermediate-export-image] -> [Lua script -> exiftool to strip tags] -> [Disk Exporter] -> [Exported file]

Potentially this would mean either other exporters don't add the same tags or if they do, they have duplicate code from the disk exporter.

The following output is from exiftool on the exported image. i.e. this is the data added by the disk exporter. ======================================= Export as JPG / PNG ===========================================
File Name : img_0001_01.jpg
Directory : .
File Size : 6.4 MB
File Modification Date/Time : 2014:01:01 10:40:12-05:00
File Permissions : rw-rw-r--
File Type : JPEG
MIME Type : image/jpeg
XMP Toolkit : XMP Core 4.4.0-Exiv2
Rating : 1
Derived From : *************
Xmp version : 1
Raw params : 0
Auto presets applied : 1
Creator : *************
Rights : *************
Subject :
Colorlabels :
Mask id :
Mask type :
Mask name :
Mask version :
Mask :
Mask nb :
Mask src :
History modversion : 1, 2
History enabled : 1, 1
History operation : sharpen, basecurve
History params : 000000400000003f0000003f, gz09eJxjYIAAM6vnNnqyn22E9n235b6aa3cy6rVdRaK9/Y970fYf95bbMzA0QPEoGEqADYnNhMQGAO0WEJo=
Blendop params : gz12eJxjYGBgkGAAgRNODESDBnsIHll8ANNSGQM=, gz12eJxjYGBgkGAAgRNODESDBnsIHll8ANNSGQM=
Blendop version : 7, 7
Multi priority : 0, 0
Multi name : ,
Hierarchical Subject :
Image Width : 4722
Image Height : 3142
Encoding Process : Baseline DCT, Huffman coding
Bits Per Sample : 8
Color Components : 3
Y Cb Cr Sub Sampling : YCbCr4:4:4 (1 1)
Image Size : 4722x3142

======================================== Export as TIFF ======================================
ExifTool Version Number : 8.60
File Name : img_0001.tif
Directory : .
File Size : 78 MB
File Modification Date/Time : 2014:01:01 11:31:02-05:00
File Permissions : rw-rw-r--
File Type : TIFF
MIME Type : image/tiff
Exif Byte Order : Big-endian (Motorola, MM)
Image Width : 4722
Image Height : 3142
Bits Per Sample : 16 16 16
Compression : Deflate
Photometric Interpretation : RGB
Fill Order : Normal
Make : *************
Camera Model Name : *************
Strip Offsets : (Binary data 439 bytes, use -b option to extract)
Orientation : Horizontal (normal)
Samples Per Pixel : 3
Rows Per Strip : 64
Strip Byte Counts : (Binary data 398 bytes, use -b option to extract)
X Resolution : 300
Y Resolution : 300
Planar Configuration : Chunky
Resolution Unit : inches
Software : darktable 1.4
Modify Date : 2014:01:01 11:30:59
Artist : *************
Predictor : None
XMP Toolkit : XMP Core 4.4.0-Exiv2
Derived From : *************
Xmp version : 1
Raw params : 0
Auto presets applied : 1
Creator : *************
Rights : *************
Subject :
Colorlabels :
Mask id :
Mask type :
Mask name :
Mask version :
Mask :
Mask nb :
Mask src :
History modversion : 1, 2
History enabled : 1, 1
History operation : sharpen, basecurve
History params : 000000400000003f0000003f, gz09eJxjYIAAM6vnNnqyn22E9n235b6aa3cy6rVdRaK9/Y970fYf95bbMzA0QPEoGEqADYnNhMQGAO0WEJo=
Blendop params : gz12eJxjYGBgkGAAgRNODESDBnsIHll8ANNSGQM=, gz12eJxjYGBgkGAAgRNODESDBnsIHll8ANNSGQM=
Blendop version : 7, 7
Multi priority : 0, 0
Multi name : ,
Hierarchical Subject :
Rating : 1
Rating Percent : 20
Copyright : *************
Date/Time Original : 2013:12:22 12:12:39
Image Size : 4722x3142

===========================================================

Associated revisions

Revision 4e5f76cf (diff)
Added by Pascal de Bruijn about 6 years ago

imageio: true should be TRUE

this fixes 0d874257deed1469316fe770611e32a989db680c
related to bug #9756

Revision 3f61347f (diff)
Added by Pascal de Bruijn about 6 years ago

imageio: true should be TRUE

this fixes 0d874257deed1469316fe770611e32a989db680c
related to bug #9756
(cherry picked from commit 4e5f76cfd86bfeddb839782070a3a720ec4b5ee6)

History

#1 Updated by Jérémy Rosen about 6 years ago

  • % Done changed from 0 to 50
  • Assignee set to Jérémy Rosen
  • Status changed from New to In Progress
  • Category set to Lua

this is due to line 227 of imageio/storage/disk.c which was introduced in commit e4f8c9b7

need to ask hanatos why this was added to disk.c and not in export_image_with flag

#2 Updated by Jérémy Rosen about 6 years ago

ok, discussed with hanatos

some storages need to add exif data, other don't want them. I need to move the call into the export function, but I need to add an extra flag to know if the exif data needs to be added.

#3 Updated by Jérémy Rosen about 6 years ago

  • % Done changed from 50 to 100
  • Target version set to Candidate for next minor release
  • Status changed from In Progress to Fixed

Also available in: Atom PDF

Go to top