Project

General

Profile

Bug #9704

Multi-instance names

Added by Roman Lebedev over 5 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
Category:
-
Start date:
12/02/2013
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Steps to reproduce:
  1. Choose some image with clean history stack, create it's duplicate
  2. Open first image in darkroom
  3. Create second instance for any module, remember module name, and take a look at MI naming: it is correct - original instance have no number, new instance is "... 1"
  4. Switch to second image (with Space in my tests)
  5. Look at the remembered module: there is only one instance, but it has "... 1" in it's name...

History

#1 Updated by Pascal Obry over 5 years ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress
  • Assignee set to Pascal Obry
  • Priority changed from Low to Medium
  • Target version set to Candidate for next major release

#2 Updated by Pascal Obry over 5 years ago

  • % Done changed from 50 to 70
  • Status changed from In Progress to Patch attached

see pull request #389

#3 Updated by Roman Lebedev over 5 years ago

Tested.
Generally, it's fine, no regressions found.
However i was able to find one issue:
  1. Choose some image with clean history stack, create it's duplicate
  2. Open first image in darkroom
  3. Create second instance for any module (do not enable any of the module instances!), remember module name, and take a look at MI naming: it is correct - original instance have no number, new instance is "... 1"
  4. Switch to second image (with Space in my tests)
  5. Switch back to first image
  6. Look at the remembered module: there is only one instance, but it has "... 1" in it's name...
    And it will stay in that way even if you switch back and forth between LT and DR.
  7. Switch to second image (with Space in my tests)
  8. Look at the remembered module: there is only one instance, but it has "... 1" in it's name...
    It will be corrected back to normal after switch back and forth between LT and DR.

#4 Updated by Pascal Obry over 5 years ago

Ok, can reproduce but this is not the same issue and is already present in master. I'll see if I can do something about this...

#5 Updated by Pascal Obry over 5 years ago

New version proposed which fixes last issue. Can you test again? Thanks.

#6 Updated by Roman Lebedev over 5 years ago

Tested.
All the issues stated above seems to be fixed, so it is generally ok.

However i have found yet another one, but this is definitely not a regression in this patch.
Steps to reproduce:
However i was able to find one issue:
  1. Choose some image with clean history stack, create it's duplicate
  2. Open first image in darkroom
  3. Create second instance for any module, remember module name, and take a look at MI naming: it is correct - original instance have no number, new instance is "... 1"
  4. Delete FIRST (original, without number) module instance
  5. Look at the remembered module: there is only one instance, but it has "... 1" in it's name...
    And it will stay in that way even if you switch back and forth between LT and DR.
  6. Switch to second image (with Space in my tests)
  7. Look at the remembered module: there is only one instance, but it has "... 1" in it's name...
    It will be corrected back to normal after switch back and forth between LT and DR.

#7 Updated by Pascal Obry over 5 years ago

Ok, step 5 is ok. the name does not convey the order at all and it was planed at some point to be able to edit the name.

step 7 means that we are missing an update of the module header somewhere. I'm not going to fix this in the current patch which must stay as simple as possible to have a chance to be integrated into 1.4 and because this is a quite marginal issue after all.

Thanks a lot of testing.

#8 Updated by Pascal Obry over 5 years ago

  • % Done changed from 70 to 100
  • Status changed from Patch attached to Fixed

Closing as now merged.

Also available in: Atom PDF