Project

General

Profile

Feature #9631

Dark window borders for Gnome 3

Added by False Identity about 4 years ago. Updated about 3 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
General
Target version:
Start date:
10/26/2013
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

As the title says - enable dark window borders for Gnome 3.

Some info on how to do that: https://github.com/phillipberndt/pqiv/issues/2

Workaround: http://pastebin.com/X8CXND4u (works only for main window; is used like this: start-dark darktable )


Related issues

Duplicated by darktable - Feature #10459: Border of application window should be dark Duplicate 05/13/2015

History

#1 Updated by Pascal de Bruijn about 4 years ago

  • Target version set to Candidate for next patch release

Actually that is quite helpful, I did a first attempt at porting the code example:

https://github.com/darktable-org/darktable/commit/56d67620f985ab58f62b93967887147f8c400f66

That said, I don't use a GNOME 3 desktop, so I'd appreciate it if you could test it on your end. Assuming it works, would you mind attaching a screenshot?

This change is available in git in our master branch, as well in darktable-1.2.x (the current stable maintenance branch).

#2 Updated by False Identity about 4 years ago

It still has light border, no signs of _GTK_THEME_VARIANT (even of any other type than UTF-8) when checking with xprop. Yes, it has to be UTF-8. I thought it was said in the linked github issue, but it wasn't...

I'm a noob when it comes to building. I had to install some libs, but some were optional. Is it possible that it did build without a library responsible for X properties? Or would the build fail?

#3 Updated by Pascal de Bruijn about 4 years ago

  • Target version changed from Candidate for next patch release to Future

Since it didn't work I reverted the previous commit.

I don't have more time to invest in this issue. But we'd gladly accept a tested patch though.

Otherwise this will have to wait until we've completed a GTK3 port.

#4 Updated by Pascal de Bruijn over 3 years ago

  • Assignee set to Roman Lebedev
  • Affected Version set to git development version
  • bitness set to 64-bit
  • System set to all

#5 Updated by Roman Lebedev about 3 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

I believe this has been fixed some time during GTK+-3 switch.

#6 Updated by Roman Lebedev over 2 years ago

  • Duplicated by Feature #10459: Border of application window should be dark added

Also available in: Atom PDF