Project

General

Profile

Feature #9628

No instance number for multi-instance modules is displayed in LT's image history tooltip

Added by Roman Lebedev almost 5 years ago. Updated almost 5 years ago.

Status:
Fixed
Priority:
Low
Category:
Lighttable
Start date:
10/21/2013
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I mean the tooltip that is shown when mouse is placed ontop of this indicator: http://www.darktable.org/usermanual/images/lighttable_thumb_icon_altered.jpg
How to reproduce: create 2 instances of some module, switch to LT, place mouse on that indicator.

Associated revisions

Revision 5b08841f
Added by Tobias Ellinghaus almost 5 years ago

Show MI name in lighttable tooltips

Fixes #9628.

Revision af962825
Added by Tobias Ellinghaus almost 5 years ago

Show MI name in lighttable tooltips

Fixes #9628.
(cherry picked from commit 5b08841f8a0ea00d1f94029cc50714afb70cc121)

Revision 9d8dc483
Added by Tobias Ellinghaus almost 5 years ago

Fix #9628 even more
(cherry picked from commit c42e8f9b9fc3176a0d8dda3dcb25822331f424ad)

Revision bd52b835
Added by Roman Lebedev almost 5 years ago

Merge remote-tracking branch 'upstream/master' into gtk3-upstream

  • upstream/master: (42 commits)
    usermanual: various additions and fixes
    Updated Dutch translation
    duplicates in lighttable mode: keep them in order of version number
    fix snprintf statement
    image COPY: also copy history stack and take care of duplicate handling
    image duplicates: on DELETE of last duplicate also delete all orphaned xmp files
    Update French translation.
    Check proper version of the XMP when reseting a local cache copy.
    Fix #9628 even more
    release cache before the lr import circuitry.
    xmp files: make parsing of uncompressed data more bullet proof
    Silence the CMake Warning
    zxmp: initialize variable do_compress to avoid compiler warnings
    image duplicates: fix handling of sidecar files (#9621)
    Show MI name in lighttable tooltips
    Update the collection count cache in more cases
    When changing stars to a picture, make sure we update lighttable view.
    Code refactoring for updating the lightable internal cache.
    fix: Visualize some sliders better: - Balance sliders dont get highlighted at the left side of the handle, does not make sense for them - Slider highlighting is done by luminosity change only, so colored sliders retain their color (use CAIRO_OPERATOR_HSL_LUMINOSITY) - split toning's balance is now also colored in the two colors to balance between - increase slider coloring slightly from 0.2f to 0.25f
    Simplify pattern matching in collect's folder mode
    ...

History

#1 Updated by Tobias Ellinghaus almost 5 years ago

  • Tracker changed from Bug to Feature
  • Target version set to Candidate for next minor release
  • Assignee changed from Aldric Renaudin to Tobias Ellinghaus
  • Status changed from New to In Progress
  • Category set to Lighttable
  • % Done changed from 0 to 50

#2 Updated by Tobias Ellinghaus almost 5 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

Applied in changeset darktable|commit:5b08841f8a0ea00d1f94029cc50714afb70cc121.

#3 Updated by Roman Lebedev almost 5 years ago

Yes, but "0" is displayed in the name of first instance of modules with MI.

#4 Updated by Tobias Ellinghaus almost 5 years ago

That is strange, I guess it's an oldish history stack. In my recent tests I get " " as the multi instance name in the db. I will take care of the "0".

Also available in: Atom PDF