Project

General

Profile

Bug #9577

DngOpcodes.cpp: 2 * out of bounds array accesses

Added by David Binderman almost 6 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Low
Category:
Darkroom
Start date:
09/05/2013
Due date:
% Done:

100%

Affected Version:
1.2.2
System:
Fedora/RHEL
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I just ran the static analysis checker cppcheck over the source
code of darktable-1.2.2

It said

[darktable-1.2.2/src/external/rawspeed/RawSpeed/DngOpcodes.cpp:254]: (error) Buffer is accessed out of bounds: mLookup
[darktable-1.2.2/src/external/rawspeed/RawSpeed/DngOpcodes.cpp:343]: (error) Buffer is accessed out of bounds: mLookup

I've checked these two and I agree with cppcheck.

Suggest code rework.

History

#1 Updated by Pascal de Bruijn almost 6 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

RawSpeed is imported code, I'll pass the message to RawSpeed's author.

#2 Updated by Pascal de Bruijn almost 6 years ago

  • Priority changed from Medium to Low
  • Assignee set to Pascal de Bruijn
  • % Done changed from 20 to 100
  • Category set to Darkroom
  • Status changed from Triaged to Fixed
  • Target version set to Candidate for next major release

Also available in: Atom PDF