Project

General

Profile

Feature #9541

Define default language

Added by Richard Wonka about 5 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Target version:
Start date:
07/30/2013
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

See also pull request number 274

The default language in darktable is currently a mix of en_US, en_GB and some Germish / foreign sounding wording.

after feedback from boucman, preference among the devs is en_GB.

I suggest creating three translations, one en_GB, one en_US and a default en which points to the devs' preferred English dialect.

I have not read the manual in a while, but I would guess that this is an issue there as well.

History

#1 Updated by Tobias Ellinghaus about 5 years ago

  • % Done changed from 0 to 20
  • Target version set to Future
  • Status changed from New to Triaged

It seems there was some misunderstanding. We personally prefer British English, but since US English is standard for software we should use that in our strings. So the plan is to find problems with our wording, fix it to be correct US English (but not to the point of writing "thru" and similarly beautiful things), and on top of that you are welcome to provide a nice British translation.

#2 Updated by Richard Wonka about 5 years ago

oh, okay.

I have just issued a pull request adding the en_GB.po and - not fully understanding how git(-hub) works, I later added a copyt of that same file as en.po to set a default.

I was thinking that we could use po.files also for the default language, as that means we have only one file to look at for any language-related issues instead of sifting through the entire source tree. - Am I making sense?

#3 Updated by Richard Wonka about 5 years ago

okay, pull request is now as cleaned up as I can get it.

git revert
is how one does that, right?

I am having a hard time keeping my repository clean...

#4 Updated by Tobias Ellinghaus about 5 years ago

  • % Done changed from 20 to 50
  • Status changed from Triaged to In Progress

Richard Wonka wrote:

oh, okay.

I have just issued a pull request adding the en_GB.po and - not fully understanding how git(-hub) works, I later added a copyt of that same file as en.po to set a default.

I was thinking that we could use po.files also for the default language, as that means we have only one file to look at for any language-related issues instead of sifting through the entire source tree. - Am I making sense?

I know what you mean, but that is not the way to go. The default language is not "en" but whatever people set in their environment variables. Just in case nothing is set (or if we don't have what people want) we revert to some kind of built in default, and that is what we write in our code. Shipping "en.po" makes absolutely no sense, since no one would set "en" as his system language when 99.999% of all applications are English anyway. So please, just do a translation to British English and people who want that can configure the system accordingly. Everything else needs proper fixing.

If you don't want to go to the code to do changes to the strings you can just write them down, collect them and send a mail to the devel list so we can look at them and decide which to actually change.

This has nothing to do with a default language though, so I am not sure if this ticket shouldn't be closed.

#5 Updated by Richard Wonka about 5 years ago

Okay then, I'll see if I can't nudge some strings around.

I have also noticed that there is a bit of negative language around that may be grammatically correct, but is less useful than positive statements. <enter 2 hour talk on human language in user interfaces and education here>

e.g. "don't do this" vs. "do that instead of this" - I will put positive and, where possible, productive language where I can.

As the strings within the code are de-facto the default language, I think we can still use this issue and define the default language as "en_US", which is what is to be used in the code. - That way you can close it as "fixed" instead of "invalid" or such. feels better, doesn't it? :-)

#6 Updated by Tobias Ellinghaus about 5 years ago

  • Status changed from In Progress to Fixed
  • % Done changed from 50 to 100

"Fixed" it is then. :)

About positive vs. negative wording, feel free to tell us about those strings, but we have to decide for each one individually if they could be changed. Well, we will see.

Also available in: Atom PDF