Project

General

Profile

Bug #9534

filter list in header does not reflect status on startup

Added by Richard Wonka almost 7 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Low
Category:
Lighttable
Start date:
07/24/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The filter drop down list that allows filtering for rejected, all except rejected, etc. always shows "unstarred only" when I start darktable, which is not what is actually shown in the lighttable.

Associated revisions

Revision f496fbdc (diff)
Added by Tobias Ellinghaus over 6 years ago

Fix #9534 by cleaning up the filter code a bit

The problem was that "no rejected" was setting the filter to "0+" with
different filter flags. This couldn't get translated back to an entry of
the combobox though, so it got set to "all".

History

#1 Updated by Richard Wonka almost 7 years ago

thinking abou this, I think defaulting to "all except rejected" or the last setting would make sense.

#2 Updated by Tobias Ellinghaus almost 7 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

I can't confirm this, for me it works as it should, i.e., it remembers the setting when shutting down. Could you please tell us the value of plugins/collection/filter_flags in your darktablerc?

#3 Updated by Richard Wonka almost 7 years ago

plugins/collection/filter_flags=6

#4 Updated by Szabolcs Szilágyi over 6 years ago

I have the same issue what Richard described and bit more, that I think is also related to this issue:
In lighttable mode I select the "all except rejected" filter then I switch to darkroom mode and back to lighttable mode, the filter's text changes to "unstarred only". Now I wrote filter's text, because I actually see all my starred pictures and no rejected ones, nor unstarred ones.
So in short:
  • lighttable mode
  • filter set to "all except rejected"
  • switch to darkroom mode
  • back to lighttable mode
  • and while the filter now says "unstarred only" I still see the same pictures as the "all except rejected" filter would allow showing.

(Arch linux with darktable 1.2.3 and plugins/collection/filter_flags=6)

#5 Updated by Tobias Ellinghaus over 6 years ago

  • System changed from Ubuntu to all
  • Target version set to Candidate for next minor release
  • Status changed from Incomplete to Triaged

Thanks, with these steps I could confirm it. It is already set to the wrong value once darkroom is entered.

#6 Updated by Tobias Ellinghaus over 6 years ago

  • Assignee set to Tobias Ellinghaus

#7 Updated by Tobias Ellinghaus over 6 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:f496fbdca2bbfedd55cd2899f3334bc48b29c2f9.

Also available in: Atom PDF

Go to top