Project

General

Profile

Bug #9482

Exposure module's Auto rectangle user selection does not take image orientation/rotation into account

Added by Nicolas Dade over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Medium
Category:
Darkroom
Start date:
06/25/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
git stable branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The Exposure module will perform an automatic exposure of a rectangular area drawn by the user on the image.

When the image is rotated by the Orientation module (which stacks above the Exposure, so is not present at Expo's input) the rectangle used is incorrect. It appears the rectangle drawn by the user is not being reverse-rotated to take the Orientation into account. So the Exposure uses the wrong coordinates, and when the image has bright in one corner and dark in the other three corners the result is very noticeably off.

As a work-around I temporarily disable Orientation, select the rectangle for auto-exposure, get the Exposure settings where I want them, and re-enable Orientation.

The same is true for rotations from the Crop and Rotate module.

Associated revisions

Revision 1d4e8db6 (diff)
Added by Ulrich Pegelow over 6 years ago

color picker: backtransform picker coordinates; fixes #9482

coordinates of local color picker need to be transformed back from the preview
image to the module in focus, else we pick completely bogus spots if distorting
modules are in action.

Revision 1b81eb85 (diff)
Added by Ulrich Pegelow over 6 years ago

color picker: backtransform picker coordinates; fixes #9482

coordinates of local color picker need to be transformed back from the preview
image to the module in focus, else we pick completely bogus spots if distorting
modules are in action.
(cherry picked from commit 1d4e8db69fe35f9b3ac22c788e6d3f6e804944ec)

History

#1 Updated by Ulrich Pegelow over 6 years ago

  • % Done changed from 0 to 10
  • Target version set to Candidate for next minor release
  • Priority changed from Low to Medium
  • Assignee set to Ulrich Pegelow
  • Status changed from New to Confirmed

The bug goes even further. Also the local color pickers as used in parametric masks are affected.

#2 Updated by Ulrich Pegelow over 6 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

Should be fixed now in master.

Also available in: Atom PDF

Go to top