Project

General

Profile

Bug #9468

Path masks cannot be shrinked

Added by Claus Allweil about 6 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Critical
Category:
Masks
Start date:
06/14/2013
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi Aldric,

for some weeks I have the problem that path masks can be enlarged by scrolling the mouse wheel down, but they cannot be shrinked by scrolling the mouse wheel up.

That has been worked some while ago, but I am not sure when this bug was introduced.

I have look through the code and found a line which looks suspicious. When I delete that line shrinking of path masks works again. But I am not sure which side effects that has.

Here is the diff of my little change:

darktable@quadlix:~/darktable-git/darktable$ diff ./src/develop/masks/path.c ./src/develop/masks/path.c.org
872c872
<       //  if (amount < 1.0 && surf < 0.00001) return 1;
---
>         if (amount < 1.0 && surf < 0.00001) return 1;

I hope that helps.

Kind regards
Claus

History

#1 Updated by Christian iuga about 6 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

Bug confirmed (for me), i have the same issue.
I think's it's important to resolved before the next major version.

#2 Updated by Simon Spannagel about 6 years ago

Christian iuga wrote:

I think's it's important to resolved before the next major version.

No hurry, that will take some time anyway...
:)

#3 Updated by Aldric Renaudin about 6 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

hi,
this should be fixed in master
thanks for reporting

#4 Updated by Claus Allweil almost 6 years ago

Thanks Aldric, I can confirm that the bug is fixed for me!

Thanks for the quick response. I love your multiple instances and masking features! That was exactly what I was missing with darktable.

Also available in: Atom PDF