Project

General

Profile

Bug #9456

Compile Error (git 20130606)

Added by R G almost 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
Category:
-
Start date:
06/07/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Compiling from git on up-to-date ArchLinux produces the following compile error.

Scanning dependencies of target denoiseprofile
[ 82%] Building C object src/iop/CMakeFiles/denoiseprofile.dir/denoiseprofile.c.o
In file included from /home/****/src/darktable-git/src/darktable/src/iop/demosaic.c:1362:0:
/home/****/src/darktable-git/src/darktable/src/iop/amaze_demosaic_RT.cc: In function ‘amaze_demosaic_RT._omp_fn.5’:
/home/****/src/darktable-git/src/darktable/src/iop/amaze_demosaic_RT.cc:367:13: error: ‘.count.138’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     #pragma omp for schedule(dynamic) collapse(2) nowait
             ^
/home/****/src/darktable-git/src/darktable/src/iop/amaze_demosaic_RT.cc:367:13: note: ‘.count.138’ was declared here
     #pragma omp for schedule(dynamic) collapse(2) nowait
             ^
/home/****/src/darktable-git/src/darktable/src/iop/amaze_demosaic_RT.cc:367:13: error: ‘.count.139’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     #pragma omp for schedule(dynamic) collapse(2) nowait
             ^
/home/****/src/darktable-git/src/darktable/src/iop/amaze_demosaic_RT.cc:367:13: note: ‘.count.139’ was declared here
     #pragma omp for schedule(dynamic) collapse(2) nowait
             ^
cc1: all warnings being treated as errors
make[2]: *** [src/iop/CMakeFiles/demosaic.dir/demosaic.c.o] Error 1
make[1]: *** [src/iop/CMakeFiles/demosaic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Linking C shared module libcolorzones.so
Linking C shared module libdenoiseprofile.so
[ 82%] Built target denoiseprofile
[ 82%] Built target colorzones
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

Associated revisions

Revision 1a3ec60c (diff)
Added by Tobias Ellinghaus about 6 years ago

Re-enable collapse(2) in amaze

See bug #9456. If it fails again, we can either revert this commit or
try to find out why/for what compiler it fails to build and work around
that.

Revision 68bff759 (diff)
Added by Tobias Ellinghaus about 6 years ago

Use collapse(2) when not building with gcc 4.8.1

See bug #9456.

History

#1 Updated by Pascal de Bruijn almost 7 years ago

Which version of gcc are you using (please paste gcc -v).

Also, would you mind locally testing the attached patch?

#2 Updated by R G almost 7 years ago

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.8.1/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /build/gcc/src/gcc-4.8.1/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --enable-gnu-unique-object --enable-linker-build-id --enable-cloog-backend=isl --disable-cloog-version-check --enable-lto --enable-gold --enable-ld=default --enable-plugin --with-plugin-ld=ld.gold --with-linker-hash-style=gnu --disable-install-libiberty --disable-multilib --disable-libssp --disable-werror --enable-checking=release
Thread model: posix
gcc version 4.8.1 (GCC)

#3 Updated by R G almost 7 years ago

I would love to try out the patch. :)

#4 Updated by R G almost 7 years ago

builds fine now.

#5 Updated by Pascal de Bruijn almost 7 years ago

  • % Done changed from 0 to 100
  • Target version set to Candidate for next minor release
  • Priority changed from Medium to High
  • Status changed from New to Fixed

I'm guessing this is actually a gcc 4.8 bug, but since distro's are slowly moving toward gcc 4.8 we'll eventually have to deal with this anyhow. This workaround however may degrade AMaZE performance a little though:

https://github.com/darktable-org/darktable/commit/a2c47e5104400996f1e558c6a41bc7837c62364e

Also available in: Atom PDF

Go to top