Project

General

Profile

Feature #9442

imrpove usability of the mipmap cache setting

Added by Antoine Beaupré almost 5 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
General
Start date:
05/26/2013
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The memory in bytes to use for mimap cache setting is rather cryptic. Plus, the tooltip only says:

(needs restart)

... which is great, but will be missed by most and doesn't explain what the heck is a mipmap cache. :)

Associated revisions

Revision 3e7e96ee
Added by Tobias Ellinghaus over 4 years ago

Fix #9442: Add a description of cache size prefs

Revision 87487fab
Added by Roman Lebedev over 4 years ago

Merge remote-tracking branch 'upstream/master' into gtk3-upstream

  • upstream/master: (84 commits)
    Try to load profile names that are not ASCII
    Resolve memory leak of 'border_init'
    [l10n] Swedish update
    usermanual: a few changes
    Update French translation.
    Use US English in hotpixels
    Updated Dutch translation
    Italian translation updated
    Update French translation.
    Fix some minor mem leaks due to metadata handling
    Clarify that our linear RGB is Rec709
    key accelerators: fix a few potential NULL pointer references. fixes #9632
    Fix #9382: Let the ctrl-t suggestion box grow
    Fix mouse scroll in z-mode of lighttable.
    Fix a clang warning about uninitialized memory
    Fix two memleaks, thanks clang for noticing
    Use a larger buffer to avoid a crash due to possibly long translations.
    Fix #9442: Add a description of cache size prefs
    [l10n] Swedish update, forgot to unfuzzy
    Fix #9567: Only export the current image from dr
    ...

History

#1 Updated by Antoine Beaupré almost 5 years ago

  • % Done changed from 0 to 70
  • Target version changed from Future to Candidate for next minor release
  • Status changed from New to Patch attached

Here's some wording that would look a little better:

--- data/darktableconfig.xml.in.orig    2013-05-26 17:32:24.095134510 -0400
+++ data/darktableconfig.xml.in 2013-05-26 17:32:31.939214137 -0400
@@ -26,8 +26,8 @@
     <name>cache_memory</name>
     <type>int</type>
     <default>536870912</default>
-    <shortdescription>memory in bytes to use for mipmap cache</shortdescription>
-    <longdescription> (needs a restart) </longdescription>
+    <shortdescription>maximum memory in bytes to use for cache</shortdescription>
+    <longdescription>this controls how much memory is going to be used, also known as the mipmap cache. this cache is used for thumbnails and other buffers (needs a restart).</longdescription>
   </dtconfig>
   <dtconfig prefs="core">
     <name>worker_threads</name>

It may not be accurate though, I wrote this only after a quick review of the code and discussions on IRC. Note that I removed the "mipmap" keyword that means absolutely nothing to the user from the main setting text.

#2 Updated by Tobias Ellinghaus over 4 years ago

  • % Done changed from 70 to 100
  • Status changed from Patch attached to Fixed

Applied in changeset darktable|commit:3e7e96eec43e29fece475c119fa357e4d6fb8e03.

Also available in: Atom PDF