Project

General

Profile

Bug #9388

Discrepancy between tooltip for "demosaicing" preference and actual behavior

Added by Daniel Wagenaar over 6 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
04/22/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
hardware architecture:
amd64/x86

Description

In Darktable 1.2 (and perhaps other versions), there is a discrepancy between the tooltip for the "core options/demosaicing for zoomed out darkroom mode" preference and the actual behavior of demosaicing in darkroom mode: The tooltip (and the name of the option) suggests that demosaicing algorithm is only overwritten by this option when zoom is less than 1:1. In fact, it is overwritten even when zoom is 1:1 or larger. The relevant code is line 671 in demosaic.c:

const int qual = get_quality();
int demosaicing_method = data->demosaicing_method;
if(piece->pipe->type == DT_DEV_PIXELPIPE_FULL && qual < 2) // only overwrite setting if quality << requested and in dr mode
demosaicing_method = DT_IOP_DEMOSAIC_PPG;

I think this should be:

const int qual = get_quality();
int demosaicing_method = data->demosaicing_method;
if(piece->pipe->type == DT_DEV_PIXELPIPE_FULL && qual < 2 && roi_out->scale<=.99999f) // only overwrite setting if quality << requested and in dr mode
demosaicing_method = DT_IOP_DEMOSAIC_PPG;

Naturally, I would be happy to submit this as a patch, but it is perhaps so simple that some existing developer can just take care of it. (Assuming that you agree.)


Related issues

Has duplicate darktable - Bug #9242: "demosaicing for zoomed out dr mode" pref option misbehavesDuplicate02/07/2013

Associated revisions

Revision 963629ea (diff)
Added by Dan Torop over 5 years ago

1:1 view demosaicer fixups

This fixes #9388, which applies to all sensors -- make 1:1 view use
chosen demosaicer in mid-quality config.

Update demosaic plugins/darkroom/demosaic/quality conf to mention VNG
in longdescription as x-trans' PPG equivalent. This leaves the config
choice inaccurate for x-trans, but at least doesn't break exsiting
configs. (If change this message to "at most PPG/VNG (reasonable)" then
demosaic will still do the right thing with exiting configs, but the
preferences screen will show a blank entry for this choice
until the user next changes it.)

History

#1 Updated by Igor Kuzmin over 6 years ago

  • Status changed from New to Duplicate

#2 Updated by Igor Kuzmin over 6 years ago

  • % Done changed from 0 to 10
  • Status changed from Duplicate to Confirmed

after thinking about it, your report is better written, so I'll mark original bug as duplicate and leave yours open

#3 Updated by Daniel Wagenaar over 6 years ago

For the record, this bug does not affect export. (In bug report #9242 this was left as an open question.)

#4 Updated by Tobias Ellinghaus about 6 years ago

  • System changed from Ubuntu to all
  • Affected Version changed from 1.2 to git development version
  • % Done changed from 10 to 20
  • Status changed from Confirmed to Triaged

Any thoughts about this? Jo? It looks reasonable to me.

#5 Updated by Dan Torop over 5 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Also available in: Atom PDF

Go to top