lens correction enhancement - more understandable interface
The lens correction module has not very user oriented UI.
- 'corrections' is presented as a pull down menu of all the possible combinations of TCA/distortion/vignetting corrections, this choice make it hard, for the new users and the users who do not like reading hard, to find the correct choice. The straigh forward solution will be introduction of the checkboxes with short labels/icons with appropriate help text (now the abbreviation TCA is not explained)
- all the following widgets: 'geometry', 'scale' .. 'tca blue' have no clear connection with the correction they are affecting. The solution will be to group them together with the correction they are affecting. More over, they have no effect (tca ...), when 'none' corrections is chosen, although they have the same look and feel. The use of disabled widgets can address this. One obvious 'mistake' is the mode of correction - does it affect all the corrections together, if yes why it is so?
I understand that blind introduction of more adjustable parameters in the lens correction module is not the solution. The module may be splitted, or even introduce some hierarchy to hold all the functionality.
#1 Updated by Torsten Bronger over 6 years ago
Here is my proposal:
- Drop "mode". I don't think this has real usecases. Besides, it is buggily implemented in LensFun, and nobody is willing to fix it.
- The four correction entities distortion, TCA, vignetting, and scale have three settings "auto", "off", and "manual". Only if "manual" is set, the single slider appears.
- When the module is activated, reset, or when camera, lens, focal length, aperture, or distance is changed, every correction entity which is not set to "manual" is set to "auto" or "off", depending on availability of LensFun data. For scaling, this means "auto".
- There is only one slider per correction entity. For distortion, it is the "b" parameter of the ptlens model, for TCA, it is the combined value of blue and red, and for vignetting, it's the scaling of the correction function.
This "correction function" for vignetting is the correction polynomial in case Lensfun has a vignetting profile for this lens, or a general-purpose function which still has to be determined otherwise.