Project

General

Profile

Feature #9273

lens correction enhancement - more understandable interface

Added by Jozef Sivek over 6 years ago. Updated 7 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
-
Start date:
02/18/2013
Due date:
% Done:

0%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The lens correction module has not very user oriented UI.

  • 'corrections' is presented as a pull down menu of all the possible combinations of TCA/distortion/vignetting corrections, this choice make it hard, for the new users and the users who do not like reading hard, to find the correct choice. The straigh forward solution will be introduction of the checkboxes with short labels/icons with appropriate help text (now the abbreviation TCA is not explained)
  • all the following widgets: 'geometry', 'scale' .. 'tca blue' have no clear connection with the correction they are affecting. The solution will be to group them together with the correction they are affecting. More over, they have no effect (tca ...), when 'none' corrections is chosen, although they have the same look and feel. The use of disabled widgets can address this. One obvious 'mistake' is the mode of correction - does it affect all the corrections together, if yes why it is so?

I understand that blind introduction of more adjustable parameters in the lens correction module is not the solution. The module may be splitted, or even introduce some hierarchy to hold all the functionality.


Related issues

Related to darktable - Feature #9087: Add manual lens correction moduleNew11/26/2012

Related to darktable - Feature #9272: lens correction enhancement - amount of correctionTriaged02/18/2013

Related to darktable - Bug #9105: Auto-scale in Lens Correction module doesn't happen automaticallyFixed10/13/2012

Related to darktable - Bug #9256: Unable to select lens model in the "lens correction" module for unknown camera modelIncomplete02/13/2013

Related to darktable - Bug #9999: TCA correction does not work until you choose a lensConfirmed06/23/2014

Related to darktable - Feature #10425: Lens IOP: better iteraction between autodetection and user-set paramsNew04/19/2015

History

#1 Updated by Torsten Bronger over 6 years ago

Here is my proposal:

  • Drop "mode". I don't think this has real usecases. Besides, it is buggily implemented in LensFun, and nobody is willing to fix it.
  • The four correction entities distortion, TCA, vignetting, and scale have three settings "auto", "off", and "manual". Only if "manual" is set, the single slider appears.
  • When the module is activated, reset, or when camera, lens, focal length, aperture, or distance is changed, every correction entity which is not set to "manual" is set to "auto" or "off", depending on availability of LensFun data. For scaling, this means "auto".
  • There is only one slider per correction entity. For distortion, it is the "b" parameter of the ptlens model, for TCA, it is the combined value of blue and red, and for vignetting, it's the scaling of the correction function.

This "correction function" for vignetting is the correction polynomial in case Lensfun has a vignetting profile for this lens, or a general-purpose function which still has to be determined otherwise.

#2 Updated by Torsten Bronger over 6 years ago

My proposal addresses this issue and #9087, #9272, and #9105.

#3 Updated by Roman Lebedev over 4 years ago

  • Related to Feature #9087: Add manual lens correction module added

#4 Updated by Roman Lebedev over 4 years ago

  • Related to Feature #9272: lens correction enhancement - amount of correction added

#5 Updated by Roman Lebedev over 4 years ago

  • Related to Bug #9105: Auto-scale in Lens Correction module doesn't happen automatically added

#6 Updated by Roman Lebedev over 4 years ago

  • Related to Bug #9256: Unable to select lens model in the "lens correction" module for unknown camera model added

#7 Updated by Roman Lebedev over 4 years ago

  • Related to Bug #9999: TCA correction does not work until you choose a lens added

#8 Updated by Roman Lebedev over 4 years ago

  • bitness set to 64-bit
  • System set to all
  • Affected Version set to git development version
  • Assignee set to Roman Lebedev

#9 Updated by Roman Lebedev over 4 years ago

  • Related to Feature #10425: Lens IOP: better iteraction between autodetection and user-set params added

#10 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 0 to 50
  • Status changed from New to In Progress

#11 Updated by Roman Lebedev over 1 year ago

  • % Done changed from 50 to 0
  • Status changed from In Progress to New

#12 Updated by Roman Lebedev 7 months ago

  • Assignee deleted (Roman Lebedev)

Also available in: Atom PDF

Go to top