Project

General

Profile

Bug #9257

Watermark substitution is case-sensitive and XMP parameters are not uppercase

Added by Dmitry Litvin over 6 years ago.

Status:
Closed: won't fix
Priority:
Medium
Category:
Darkroom
Start date:
02/14/2013
Due date:
% Done:

0%

Affected Version:
1.1.3
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Parameters for substitution to SVG watermarks are dfefined in the manual (http://www.darktable.org/usermanual/ch03s04s09.html.php) and are all upper-case, including XMP-related:
$(XMP.DC.CREATOR)
$(XMP.DC.PUBLISHER)
$(XMP.DC.TITLE)
$(XMP.DC.DESCRIPTION)
$(XMP.DC.RIGHTS)

However, these parameteres are NOT upper-case in the source code (http://darktable.org/redmine/projects/darktable/repository/revisions/master/entry/src/iop/watermark.c) and therefore are not substituted at all (the replacing is case-sensitive). This is how they look in the code:

$(Xmp.dc.creator)
$(Xmp.dc.publisher)
$(Xmp.dc.title)
$(Xmp.dc.description)
$(Xmp.dc.rights)

I think it makes sense to make the replacement case-insensitive. The other option is to make them upper-case in the code, it's easier, but less flexible.

History

#1 Updated by Jose Carlos Garcia Sogo over 6 years ago

  • Assignee changed from Developers to Jose Carlos Garcia Sogo

#2 Updated by Tobias Ellinghaus over 6 years ago

  • Status changed from New to Closed: won't fix

#3 Updated by Tobias Ellinghaus over 6 years ago

Ok, a short explanation why I really don't like this idea:

  • this would allow people to create watermarks that will not work in versions of darktable released in the past without any added benefit.
  • creating a watermark is a one-time thing, not a daily usability issue. So it shouldn't be a problem to copy&paste the correct variable name into your xml file.

See 14a7c099adaacc9c1112b05b34632c83995cad6a

Also available in: Atom PDF