Project

General

Profile

Bug #9223

regression - cannot select images

Added by Pascal Obry over 6 years ago.

Status:
Fixed
Priority:
Critical
Category:
Lighttable
Start date:
01/29/2013
Due date:
% Done:

100%

Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

After bisecting it turn out that the culprit is:

fc4c157596fdd9727d33dad5a8ec074783993f47 is the first bad commit
commit fc4c157596fdd9727d33dad5a8ec074783993f47
Author: Jose Carlos Garcia Sogo <>
Date: Fri Jan 25 22:29:55 2013 +0100

Make the UI behave as expected when an image rating is changed
When an image rating is changed and it gets out of the current collection the
current behaviour was not consistent, depending if the image selected was the
one being changed or not.

:040000 040000 0227bcb84511b8082c1150e619d7f473f44c9772 4017c542cad9d24dadf49f3a2cf2760d2824583e M src

Associated revisions

Revision 0ccab755
Added by Jose Carlos Garcia Sogo over 6 years ago

Mouse click is already handled in button_pressed. Fixes #9223

Mouse click for selections in lighttable is already handled in button_pressed
function, so the code for doing so has to be removed from both expose_zoomable
and expose_filemanager.

Revision c101d8f3
Added by Johannes Hanika over 6 years ago

Revert "Mouse click is already handled in button_pressed. Fixes #9223"

This reverts commit 0ccab755f33a73d025643850130fa8b9d6a24bb9.

which was breaking fluxbox event handling, making mouse clicks impossible there.

Conflicts:
src/views/lighttable.c

Revert "Make the UI behave as expected when an image rating is changed"

This reverts commit fc4c157596fdd9727d33dad5a8ec074783993f47.

Revision 42c40e0c
Added by Johannes Hanika over 6 years ago

Revert "Revert "Mouse click is already handled in button_pressed. Fixes #9223""

This reverts commit c101d8f3c1f369a195507342e5f17d504c959d17.

which in turn reverted stuff that broke fluxbox. very likely it'll stay broken
until fluxbox stops emitting random keymap and enter/leave pair events in between
mouse clicks. check via `xev'.

Revision 96dab787
Added by Jose Carlos Garcia Sogo about 6 years ago

Mouse click is already handled in button_pressed. Fixes #9223

Mouse click for selections in lighttable is already handled in button_pressed
function, so the code for doing so has to be removed from both expose_zoomable
and expose_filemanager.

History

#1 Updated by Max Killer over 6 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

It is correct that the selection behaviour was broken due to the commit fc4c157596fdd9727d33dad5a8ec074783993f47 in zoomable mode.
This is because the selection procedures from expose_filemanager were relocated to button_pressed. But the selection procedures from expose_zoomable were not changed. So in zoomable mode the selection code is more or less executed two times, but the selection code in expose_zoomable differs from the one in expose_filemanager. Therefore the "erratic" behaviour.

I cannot recreate a selection error in filemanager mode though.

#2 Updated by Jose Carlos Garcia Sogo over 6 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

Fixed in 0ccab755f33a73d025643850130fa8b9d6a24bb9

Also available in: Atom PDF