Project

General

Profile

Bug #9189

[patch] Uninitialised variables

Added by Daniel Blueman about 7 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Darkroom
Start date:
01/19/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When debugging some stability issues with git head as of a week ago, I found a couple of uninitialised variables being written out into the SQL database.

Please can you check and help me commit these fixes?

diff --git a/src/develop/pixelpipe_hb.c b/src/develop/pixelpipe_hb.c
index 631cb2b..f747bfe 100644
--- a/src/develop/pixelpipe_hb.c
++ b/src/develop/pixelpipe_hb.c
@ -183,6 +183,7 @ void dt_dev_pixelpipe_create_nodes(dt_dev_pixelpipe_t *pipe, dt_develop_t *dev)
piece->pipe = pipe;
piece->data = NULL;
piece->hash = 0;
piece->process_cl_ready = 0;
dt_iop_init_pipe(piece->module, pipe,piece);
pipe->nodes = g_list_append(pipe->nodes, piece);
}
diff --git a/src/iop/monochrome.c b/src/iop/monochrome.c
index 6f3b1c6..3db6afb 100644
--- a/src/iop/monochrome.c
+++ b/src/iop/monochrome.c
@ -108,6 +108,7 @ void init_presets (dt_iop_module_so_t *self)

p.a = 32.0f;
p.b = 64.0f;
+ p.highlights = 0.0f;
dt_gui_presets_add_generic(_("red filter"), self->op, self->version(), &p, sizeof(p), 1);
// p.a = 64.0f;

Associated revisions

Revision 30c77b3b (diff)
Added by Simon Spannagel about 7 years ago

Fix two uninitialized variables in dt core and monochrome.
Thanks to Daniel Blueman! This fixes #9189

History

#1 Updated by Simon Spannagel about 7 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Hi Daniel,

thanks for your patch, I pushed it to current git master.
(redmine should have mentioned here, but we have some problems with that repo currently...)

Simon

Also available in: Atom PDF

Go to top