Project

General

Profile

Bug #9168

Zooming in Lighttable/Filemanager mode looses active image (usability)

Added by Anton Keks over 6 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Lighttable
Start date:
12/31/2012
Due date:
% Done:

100%

Affected Version:
1.1.1
System:
unknown
bitness:
64-bit
hardware architecture:
amd64/x86

Description

A usability issue only in Filemanager mode, Lighttable mode works correctly:
Zooming in with either Ctrl+mousewheel or Alt+1 jumps to the first image that was visible previously not to the one that is hovered or selected.
This makes it really hard to go to a particular image at zoom level 1.

Btw, Z key works correctly - it temporarily zooms the current hovered image. Alt+1 should work the same: permanently zoom the current hovered image.

Associated revisions

Revision b3a52bb3
Added by Eckhart Pedersen over 6 years ago

corner's light table zooming stuff

individual commit messages were:

Changed lighttable filemanager view so that zooming does not use the upper left image as anchor, but uses the image under the mouse cursor instead.

Main fix is zooming now allows space to be created in fron of the first image, so that the image under the mouse can remain there. In order to achieve this, I found it necessary to move some code around so that the filemanager view is slightly more MVC like, i.e. the expose method does not handle user input any more. The same procedure should be done for the zoomable view, but that is for another commit...

Zooming is ultra smooth now because images are allowed to go outside the borders during the zoom. After zooming the image snap back into the grid.

fixed a problem that a previous zoom operation would mess up a following zoom operation if the view had snapped back to the grid in between. Still has an issue when there is only one image displayed...

Implemented zoom fix for Bug #9168. Smooth zooming code has been removed, so that images always stay perfectly aligned in the grid, due to simpler implementation and broader support in dev community.

Conflicts:
src/views/lighttable.c

fixed zoomable lighttable zoom bug

Revision 1cccf1d5
Added by Eckhart Pedersen over 6 years ago

Implemented zoom fix for Bug #9168. Smooth zooming code has been removed, so that images always stay perfectly aligned in the grid, due to simpler implementation and broader support in dev community.

Revision 490a341a
Added by Eckhart Pedersen about 6 years ago

Implemented zoom fix for Bug #9168. Smooth zooming code has been removed, so that images always stay perfectly aligned in the grid, due to simpler implementation and broader support in dev community.

History

#1 Updated by Emmanuel Lacour over 6 years ago

Just a quick note to say that I agree with this ;)

#2 Updated by Jose Carlos Garcia Sogo over 6 years ago

  • System set to unknown
  • % Done changed from 0 to 50
  • Target version set to Candidate for next major release
  • Status changed from New to In Progress

The bug is already fixed when using the mouse. The problem still arises when the keyboard is used.

#3 Updated by Eckhart Pedersen over 6 years ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

Applied in changeset darktable|commit:b3a52bb3e8ee4d019d342e65973ea69225516d8f.

Also available in: Atom PDF