Project

General

Profile

Feature #9040

Spot Removal and Orientation and Crop-and-Rotate modules interact badly

Added by Nicolas Dade over 5 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Start date:
11/10/2012
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

If an image has a change applied by the Orientation or the Crop-And-Rotate modules, and you go to add or edit in Spot Removal module, the image returns to the un-orientated, un-cropped/rotated state.

This doesn't seem intentional.

If it is intentional, I submit that at minimum the Orientation should be applied first. Doing spot removal on an up-side-down image is mentally taxing.

This might be related to how the Spot Removal is applied before Orientation.
I also see similar behavior between Spot Removal and the general Crop and Rotate module. And Framing, though that is less of an issue since it's usually done last.

History

#1 Updated by Ulrich Pegelow over 5 years ago

  • Tracker changed from Bug to Feature

It's intentional as it is now. Reason is that spot removal completely works in original image coordinates. We
should certainly not change this in respect to crop & rotation.

To be checked if this could be changed in respect to orientation. At least in the sense that image is shown with
corrected orientation when spot module spot removal is in focus.

=> feature request

#2 Updated by Aldric Renaudin about 5 years ago

  • % Done changed from 0 to 100
  • Target version set to Candidate for next major release
  • Status changed from New to Fixed

should be fixed in master

Also available in: Atom PDF