Project

General

Profile

Feature #9029

Use list instead of a table for plugin manager

Added by Vitaliy Filippov about 5 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Darkroom
Start date:
10/30/2012
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Now Darktable uses a table with icons for plugin manager.
And there are 50 plugins. And the user doesn't see their names, just icons.
So it's VERY irritating having to place the mouse cursor over ALL 50 (!!!) icons to find the needed module. I can't remember them all :)

I suggest using a scrollable list of labeled buttons instead of table. I think it's MUCH more usable.

Patch is attached. I had to modify the drawing routine of the tristate button, because previous code was either drawing just the text, or just the icon, but not both at the same time.

Also, I've changed flip.png icon so it now is 24x24 with margins, like all others.

0001-Use-GtkList-for-plugin-list-instead-of-a-GtkTable.patch Magnifier (8.81 KB) Vitaliy Filippov, 10/29/2012 11:38 PM

moremodules-fixed.png - Screenshot (105 KB) Vitaliy Filippov, 10/31/2012 11:52 AM

History

#1 Updated by Christian Tellefsen about 5 years ago

  • Category set to Darkroom
  • Target version set to Candidate for next major release

Thank you for your input! Personally I completely agree -- the "more-modules-module" is a pain to navigate.

There was a long and passionate debate on this topic in the mailing list a couple of weeks ago:
http://sourceforge.net/mailarchive/message.php?msg_id=29949819

The active modules list is likely to be moved to the Preferences dialogue. As we currently are in a string freeze the functionality may need to wait until after the next release.

I'm leaving this issue open, in case the patch should be pulled in as a temporary fix. (It doesn't seem to break the string freeze, might be relevant for the upcoming release?)

#2 Updated by Richard Wonka about 5 years ago

Thank you!

#3 Updated by Tobias Ellinghaus about 5 years ago

Could you please provide a screenshot of what it looks like with your patch?

#4 Updated by Vitaliy Filippov about 5 years ago

Of course, here it is :)

#5 Updated by Jérémy Rosen about 5 years ago

Ok, we had a small discussion on IRC, and here are our current comments

  • please use normal text instead of bold
  • it would make more sense to have the plugin list sorted alphabetically instead of the pipe order. Ease of search is more important than rendering hints here...
  • I haven't had time to check this myself, but please make sure you don't break string freeze... we plan to rewrite the more-module logic after the next stable release, so this patch only make sense in this stable release, and we are already in string-freeze...

Cheers
Boucman

#6 Updated by Vitaliy Filippov about 5 years ago

OK, I'll fix it.

I've also had a thought - maybe the messages should be changed so that each tristate button displays current state of the plugin, not the click action? Maybe this also will be more convenient?

Btw, what's the string freeze?

#7 Updated by Christian Tellefsen about 5 years ago

"String freeze" is one of several steps preceding release.

Strings that require translation are not allowed to be modified or added. This allows translators time to get redy before the release.

#8 Updated by Jérémy Rosen about 5 years ago

Ok, we have been discussing a little bit more how this should look like...

we believe that a simple way to do it would have to have three colums in the table

  • first column would be the module's icon
  • second column would be empty or a star if the module is a favorite (the star icon from the favorite group)
  • third column would be the module name

the three modes would be displayed in the follwing way

  • off : dark background, no star
  • on : light background, no star
  • favorite : light background, with star

this should not break string freeze since the only string used would be the module name which is already available somewhere else...

Sorry to make you rewrite the patch so much, but hopefully it can be done in time for 1.1

Cheers
Boucman

#9 Updated by Jérémy Rosen about 5 years ago

  • Status changed from Patch attached to Fixed
  • % Done changed from 70 to 100

Ok I did a commit based on your patch (though heavily reworked, the feature I asked were actually more complicated than I expected)

thx for the initial patch, though that was a good base on which to work

#10 Updated by Vitaliy Filippov about 5 years ago

Thank you very much! I've checked out the new list - I think it's very convenient.

Also available in: Atom PDF