Project

General

Profile

Bug #8971

clicking and dragging on bauhaus combobox is broken

Added by Igor Kuzmin over 7 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Start date:
10/05/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I think some time ago the change was made so that when combobox is opened, currently selected item will appear under cursor, not the first item. Seems like not all code was changed accordingly, here are steps to reproduce the issue with demosaic module as an example:
  • select "local average" (2nd item) in "match greens"
  • click on this combobox again and drag cursor to "full and local average" (4th item)
    "full average" (3rd item) will be selected. Obvious outdated logic behind that is - you dragged cursor for 2 items, so you selected 1+2=3rd item, while actually code should add 2 to currently selected item number (2), not first one, which will get the correct answer: 2+2=4th item is selected.

Associated revisions

Revision 30758dfc (diff)
Added by Johannes Hanika over 7 years ago

bauhaus: support click-drag comboboxes. fixes #8971

History

#1 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 20
  • Target version set to Candidate for next minor release
  • Status changed from New to Triaged

#2 Updated by Johannes Hanika over 7 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:30758dfcb38efaf072405802d604fcd7999ae1ca.

Also available in: Atom PDF

Go to top