Project

General

Profile

Feature #8968

Actions are not applied to all grouped images when collapsed

Added by Rick Gabriel almost 6 years ago. Updated 3 months ago.

Status:
Triaged
Priority:
Medium
Category:
Lighttable
Start date:
10/02/2012
Due date:
% Done:

20%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When viewing images shot in RAW+JPG, the new automated grouping of the images is very nice. However, when reviewing images with groups collapsed, it would be nice for rating and meta information to be applied to both the CR2 and JPG simultaneously. For example, marking the group as rejected should apply to both images. Currently, marking a collapsed group as rejected only seems to affect the raw. When expanded, the JPG is not flagged as rejected. This feature would make it easier for those who shoot in RAW+JPG.

reject_group.lua - Reject all selected and grouped images at once (964 Bytes) Thibault Jouannic, 12/30/2015 06:43 PM

rate_group.lua - applying a rating (or rejection) to all images within a group (3.03 KB) hxy io, 12/31/2015 06:13 PM

group_leader_rating.lua (1.05 KB) Jörg Mensmann, 07/09/2016 08:03 PM


Related issues

Related to darktable - Bug #10099: Rejecting group head hides other group member New 09/06/2014
Related to darktable - Bug #11382: Copy local only copies group head New 12/22/2016
Duplicated by darktable - Bug #10663: Darktable should attach tag to all images in the selected group Duplicate 10/12/2015

History

#1 Updated by Rick Gabriel almost 6 years ago

If my suggestion doesn't work for you, I'm just looking for some method of dealing with RAW+JPG files without going through each individually. ASP combines them into a single thumbnail and operations happen on the RAW only I think.

#2 Updated by Simon Spannagel almost 6 years ago

  • Tracker changed from Feature to Bug
  • % Done changed from 0 to 20
  • Affected Version set to git development version
  • Subject changed from Apply tags to all grouped images when collapsed to Tags are not applied to all grouped images when collapsed
  • Status changed from New to Triaged

Good catch, Rick.

I would even say this is not a feature request but a bug. And most likely it#s not only tags but everything else, too that workds with selection.
If groups are collapsed and I select one group all contained images should be "selected" and actions should work in all of them (deleting, assigning tags, ...)

Tobias, what do you think?

#3 Updated by Tobias Ellinghaus almost 6 years ago

Yes, I know that this functionality is missing. I was too lazy to code it.

#4 Updated by Tobias Ellinghaus almost 6 years ago

  • Assignee set to Tobias Ellinghaus
  • Target version set to Candidate for next minor release

#5 Updated by Simon Spannagel almost 6 years ago

  • Subject changed from Tags are not applied to all grouped images when collapsed to Actions are not applied to all grouped images when collapsed

Changed the title. This also affects things like dragging an image group onto the map.

#6 Updated by Tobias Ellinghaus over 5 years ago

  • Status changed from Triaged to Incomplete

I am no longer convinced that this is a good idea. If you group several images (for example bracketed shots + the generated HDR) only some images might justify a high star rating while the source images should be unstarred. The same applies when you use color labels to mark images that are to be exported.

#7 Updated by Rick Gabriel over 5 years ago

That's a good point. My main goal is to be able to deal with shots taken in RAW+JPG together instead of having to view, rate, and reject each image twice. I think some other functions might be nice to apply to a whole group too but you brought up a good use case where you might not want that. Then again, maybe we could justify assuming that if images are grouped together, the user probably wants setting to be applied to the whole groups. Otherwise, they could ungroup them. Thoughts?

#8 Updated by Anonymous over 5 years ago

I have exactly the same problem as Rick. This feature could be really usefull when working with RAW+JPG, but at the moment this disfunctionality is preventing me from using it. I also think the possibilty of ungrouping and then rating, tagging etc. the subimages in different ways is a practicable solution.

In this connection the possibility of choosing the "main" image in a group while importing would be another improvement. So I prefer to have the JPG displayed when the groups are collapsed, not the RAW. Hope you understand me :-) And thanks for this great software!!

#9 Updated by Simon Spannagel over 5 years ago

  • Tracker changed from Bug to Feature

The representative image of a group can be chosen in current git version. Use the "g" button on the image for it.
Not sure about the rest, certainly needs some more discussion, I'd convert this to a feature request again.

#10 Updated by Tobias Ellinghaus over 5 years ago

  • Target version changed from Candidate for next minor release to Future

#11 Updated by Martin Schweifer almost 5 years ago

I also miss the capability to rate jpg+raw simultaneously. For my workflow the efficiency would be highly increased. Without this feature, in ungrouped view each pair has to be rated double. I'm certain this is a benefit for the majority of users shooting jpg+raw and hope it will be implemented in a future version.

The other point of preferring the jpg as cover foto could also be meaningful. For example if someone prefers to work with jpg and rarely uses raw, a double click on the cover foto opens the right file. Selecting it using the "G" button in each group of course would work, but I think the request was meant as default setting (as an option in the menu). Maybe this should be discussed in a seperate thread.

#12 Updated by Tobias Ellinghaus almost 5 years ago

  • % Done changed from 20 to 0
  • Status changed from Incomplete to Closed: won't fix
  • Target version changed from Future to Candidate for next minor release

After having thought about this quite a lot I came to the conclusion that this should not be part of regular darktable. However, once Lua support is working as intended I guess that this would be a job for a tiny script that registers to rating/labeling signals and does the same on all other images in the same group. I am sure Boucman (Jérémy Rosen) can help with that.

#13 Updated by Torsten Bronger about 4 years ago

I was bitten by this today. I imported all pictures of my last holiday trip (RAW/JPEG groups), rejected the bad, geotagged -- and then saw that still all JPEGs were neither rejected nor geotagged.

In http://darktable.org/redmine/issues/9785 it was requested again, and Simon says in http://darktable.org/redmine/issues/9907#note-1

However, if groups are collapsed and I try to delete it, what actually happens is that the group representative (in this case the RAW file) is deleted, but the rest stays. This is somehow inconsistent and imho we should just delete the whole group in this case.

So, I ask to implement this in DT core. I think such a feature would follow the Principle of Least Surprise. If members of a group differ in geoloc, rating, description, tags, they should not be in a group in my opinion. A group is the closest possible relation of images, and should be used for RAW/JPEG pairs, panorama components, and HDR components.

#14 Updated by Simon Spannagel about 4 years ago

  • % Done changed from 0 to 20
  • Status changed from Closed: won't fix to Triaged

Maybe we can find a solution that satisfies all needs and is consistent in it's behavior. Current situation definitely is not...

#15 Updated by Reed Law over 3 years ago

Tobias Ellinghaus wrote:

After having thought about this quite a lot I came to the conclusion that this should not be part of regular darktable. However, once Lua support is working as intended I guess that this would be a job for a tiny script that registers to rating/labeling signals and does the same on all other images in the same group. I am sure Boucman (Jérémy Rosen) can help with that.

Can this be done by a Lua script now? Or is there any other workaround available?

#16 Updated by Jérémy Rosen over 3 years ago

  • Affected Version set to git development version
  • System set to all
  • bitness set to 64-bit

there is a script in the wiki that does more or less that...

you can't have an event that triggers when rating changes, but you can do a lua shortcut that will change the rating for you (thus doing the same thing)

#17 Updated by Timo Steuerwald about 3 years ago

Jérémy Rosen wrote:

there is a script in the wiki that does more or less that...

Can you please provide a link to this script?

#18 Updated by Roman Lebedev almost 3 years ago

  • Duplicated by Bug #10663: Darktable should attach tag to all images in the selected group added

#19 Updated by Michael Bewley over 2 years ago

Would it make sense to just have a setting for this? "actions applied to group affect whole group TRUE/FALSE". It seems clear that both cases are valid (I'm in the raw+jpeg camp that would prefer whole group for accept/reject).

#20 Updated by Thibault Jouannic over 2 years ago

I've been annoyed by this issue, since I'm also a raw+jpeg shooter. I realize that, depending on your workflow, you might want rating actions to be applied to only the group leader or to all group members.

I tried to write a small lua script to overcome this issue and was quite happy to discover that scripting is quite easy with darktable. Here is my script in attachment.

To use it, copy the script in ~/.config/darktable/lua and add `require "reject_group"` to the ~/.config/darktable/luarc file.

Restart Darktable, go to settings > shortcuts > lua and then assign shortcuts to "Reject all group members" (I use Shift+R) and to "Cancel grouped images rejection" (I use Ctrl+Shift+0).

Then, when pressing Shift+R, it will reject all selected images and all the images they are grouped with at once. Pressing Ctrl+Shift+0 will do the opposite and reset the rating attribute.

I don't use the 1~5 and color ratings, but the script should be quite easy to adapt and complete.

I hope this will be useful.

#21 Updated by thokster . over 2 years ago

Perfect!
Very useful, thanks!

#22 Updated by hxy io over 2 years ago

Thibault Jouannic wrote:

I don't use the 1~5 and color ratings, but the script should be quite easy to adapt and complete.

Thanks so much for your script!

I've adapted it slightly to cater for my needs to apply ratings (0-5) as well as rejections to images within a group:

  • Reject group: Ctrl+R
  • Rate group 0: Ctrl+0
  • Rate group 1: Ctrl+1
  • Rate group 2: Ctrl+2
  • Rate group 3: Ctrl+3
  • Rate group 4: Ctrl+4
  • Rate group 5: Ctrl+5

I've attached my modified script, but I've also uploaded it to a GitHub repo in the hope that others can improve and expand upon it:

https://github.com/ribmo/darktable-rate-group

https://github.com/ribmo/lua-scripts/blob/master/contrib/rate_group.lua

Edit: This is my first time playing with lua and since posting the script I've done a little refactoring. However, I can't seem to replace the attached file, so I'll continue to host the updated version on GitHub. (Unless there's an alternative way to maintain scripts preferred by the community?)

#24 Updated by hxy io over 2 years ago

Thank you. I've now submitted a pull request to have the script added to the contrib lua scripts:

https://github.com/darktable-org/lua-scripts/pull/21

#25 Updated by Martin Dahlgren over 2 years ago

Simon Spannagel wrote:

Maybe we can find a solution that satisfies all needs and is consistent in it's behavior. Current situation definitely is not...

Maybe a simple toggle in the settings 'should tags and ratings apply to all images in collapsed groups'. The Lua script is probably a great workaround (the Fedora package doesn't support Lua scripting so I can not tell) but since a jpeg+RAW-workflow is so common this functionality should probably be included in standard release.

#26 Updated by Jörg Mensmann about 2 years ago

The attached script uses a slightly different approach: It copies the star rating of the group leader (=RAW) to the other images in a group (=JPEG).

This means you can apply the ratings to the RAW files as usual, then later copy the ratings to the corresponding JPEGs. Just select all images and run the script. Useful when you already have a large library of images where the rating was only applied to the RAW files.

#27 Updated by Tobias Ellinghaus over 1 year ago

  • Related to Bug #10099: Rejecting group head hides other group member added

#28 Updated by Tobias Ellinghaus over 1 year ago

  • Related to Bug #11382: Copy local only copies group head added

#29 Updated by Trolli Schmittlauch about 1 year ago

Tobias Ellinghaus wrote:

If you group several images (for example bracketed shots + the generated HDR) only some images might justify a high star rating while the source images should be unstarred.

I don't see an issue there as groups can easily be expanded by clicking the G symbol. IMHO the "principle of least surprise" would mean that a collapsed group is treated as one object while members of an expanded group are treated as separate files.

Maybe the UI could also be improved to make this behaviour more obvious, but IMHO the current state of the UI already reflects the suggested behaviour.

#30 Updated by Trolli Schmittlauch 11 months ago

I wrote a small RFC about how groups in darktable should behave. Please give me your comments on that. https://gist.github.com/schmittlauch/03ccf97ed19154e767d920992214f8ec

TL;DR: I found two not-so-easy cases:
  • applying styles
  • duplicating members of a group

#31 Updated by Diego Cesar 9 months ago

I don't use the 1~5 and color ratings, but the script should be quite easy to adapt and complete.

Thanks for the script to rate groups. I'm also got surprised when I finished to rate/label tons of pictures and then found out they were only applied to the group header. These scripts saved a lot of extra work.

I understand it is not a simple decision, but so far I've based on scripts posted here to also label groups by color. I've made it public here:

https://gist.github.com/dbcesar/21ee10412e9310652aaa855020b1737d

Thx

#32 Updated by m laverdiere 3 months ago

I'm new to darktable (which is awesome btw) and I stumbled upon this pretty quickly, as I was culling my first imported film roll full of RAW+JPG. As far as I understand, current LUA scripts help with color labels and rejection operations, but not with tagging, so that's a big part of a regular photo management workflow that is not covered.

So +1 for integration in the "next minor release", if possible.

Also available in: Atom PDF