Project

General

Profile

Bug #8965

Vignetting (lens correction module) is not applied

Added by Torsten Bronger over 6 years ago.

Status:
Fixed
Priority:
High
Category:
Darkroom
Start date:
10/01/2012
Due date:
% Done:

100%

Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

In git-master, no anti-vignetting correction is applied. The anti-distortion works properly, though. This is a regression from 1.0.5 where it works fine.

For your convenience, I applied my correcion file for lensfun. Place it in ~/.local/share/lensfun/. If you use it (select e.g. "Sony/NEX-7" and "Sony/E 18-55mm") and select "45m" for the distance in the lens correction module, the corners should become brighter.

nex.xml Magnifier (9.91 KB) Torsten Bronger, 10/01/2012 08:26 AM

Associated revisions

Revision 2c64a357
Added by Ulrich Pegelow over 6 years ago

fix editable comboboxes; this should also fix #8965

History

#1 Updated by Ulrich Pegelow over 6 years ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed
  • Assignee set to Ulrich Pegelow
  • Priority changed from Low to High
  • Target version set to Candidate for next major release

Thanks for reporting, bug is confirmed. I have at least a first idea where to look at.

#2 Updated by Ulrich Pegelow over 6 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

Should be fixed now in git master.

#3 Updated by Rick Gabriel over 6 years ago

I wasn't aware that this was a bug because I thought it made sense to separate distortion correction from vignetting. I'd like to suggest that vignette correction be optional when activating the Lens Correction module. Here is a use case that I run into frequently: I want to process a JPG direct from my 5D Mark III. The camera already corrects for vignetting and CA but not distortion for JPGs. After importing into DT, I'd like to correct for distortion but not anything else. Perhaps an optional checkbox for vignette correction in the Lens Correction module would work?

#4 Updated by Ulrich Pegelow over 6 years ago

In fact DT always corrects whatever lensfun is able to - depending on the camera/lens profile. There is (and was) no option so far to switch on/off single corrections. I follow your point that there are valid use cases, where this behavior is too limiting.

#5 Updated by Ulrich Pegelow over 6 years ago

Requested feature has been added.

#6 Updated by Rick Gabriel over 6 years ago

Wow! Looks great, thanks!

#7 Updated by Rick Gabriel over 6 years ago

I'm still not seeing vignette correction applied from the lens correction module even when "all corrections" are enabled but distortion is corrected. In my test CR2 photo, I shot wide open at f/2.8 with my Canon 24-70mm f/2.8 (version 1). This aperture produces a fair amount of vignetting which is not corrected by the lens correction module. This is one of the most common lenses so I'd assume lensfun has a working profile for it. Again, distortion is corrected normally. Are you sure this is fixed?

#8 Updated by Torsten Bronger over 6 years ago

Unfortunately, LensFun has no vignetting profile for any lens yet.

Also available in: Atom PDF