Project

General

Profile

Bug #8959

disable group / ungroup buttons when grouping is turned off

Added by Jesper Pedersen over 7 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Lighttable
Start date:
09/29/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

  1. Select x images
  2. In the "Selected image(s) press "group" => nothing happens
  3. Press Ctrl+g => the images are grouped
  4. With the images selected press "ungroup" in "Selected image(s) => nothing happens

A Ctrl+g on the selected images doesn't ungroup the images either.

darktable: master @ 684370a2bc2e1ce1939f97f1054ec712bedc6b47 (September 29, 2012)

Associated revisions

Revision e2358cab (diff)
Added by Tobias Ellinghaus over 7 years ago

Fix #8959: allow (un)grouping when grouping is off

History

#1 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

Can't reproduce. When grouping it turned on, both the buttons as well as the shortcuts work. When grouping is turned off nothing happens as intended.

#2 Updated by Jesper Pedersen over 7 years ago

If I collapse the group, and selects it and press "ungroup" the first image in the group is removed from the group.

If I view all the images in the group (with the red border around them) and selects them all and press "ungroup" it doesn't have any effect.

#3 Updated by Jesper Pedersen over 7 years ago

Ah, got'ya - it is an usability issue then (at least for me). Maybe the "group" / "ungroup" buttons should be grey'ed out if the group functionality isn't enabled - same deal with Ctrl+g.

#4 Updated by Tobias Ellinghaus over 7 years ago

  • Target version set to Candidate for next minor release
  • Priority changed from Medium to Low
  • Status changed from Incomplete to Triaged

#5 Updated by Tobias Ellinghaus over 7 years ago

  • Subject changed from group / ungroup buttons doesn't have any effect to disable group / ungroup buttons when grouping is turned off

An alternative would be to allow grouping/ungrouping also when grouping is turned off in the top toolbar. Not sure what would be better.

#6 Updated by Jesper Pedersen over 7 years ago

I think that grouping / ungrouping should be enabled at all times, and have the top toolbar icon toggle expansion / collapse of the groups.

#7 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:e2358cab4ff0bf1efc4ca4cd87a1986371679208.

#8 Updated by Jesper Pedersen over 7 years ago

Thanks !

Also available in: Atom PDF

Go to top