Project

General

Profile

Bug #8958

Crash during latex export

Added by Jesper Pedersen over 7 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Lighttable
Start date:
09/29/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

  1. Select one image
  2. Export module: latex book
  3. Select directory /tmp/$(FILE_NAME)
  4. Title: MyBook
  5. Export
[export_job] exported to ` x.jpg'
  • glibc detected * /usr/local/bin/darktable: free(): invalid pointer: 0x00000000006170d8 *
    #0 0x0000003b6de36285 in raise () from /lib64/libc.so.6
    #1 0x0000003b6de37b9b in abort () from /lib64/libc.so.6
    #2 0x0000003b6de7774e in __libc_message () from /lib64/libc.so.6
    #3 0x0000003b6de7da76 in malloc_printerr () from /lib64/libc.so.6
    #4 0x0000003b6fe4bc53 in g_free () from /lib64/libglib-2.0.so.0
    #5 0x00007ffff7c1a43a in dt_variables_params_destroy (params=0x7ffff000c540) at /home/jp/DarkTable/darktable/src/common/variables.c:240
    #6 0x00007fff69d53dd9 in free_params (self=0xcaaee0, params=0x7ffff0003000) at /home/jp/DarkTable/darktable/src/imageio/storage/latex.c:433
    #7 0x00007ffff7c319e2 in dt_control_export_job_run._omp_fn.0 () at /home/jp/DarkTable/darktable/src/control/jobs/control_jobs.c:1306
    #8 0x00007ffff7c31318 in dt_control_export_job_run (job=0xf3dc00) at /home/jp/DarkTable/darktable/src/control/jobs/control_jobs.c:1238
    #9 0x00007ffff7c28d2c in dt_control_run_job (s=0x66e290) at /home/jp/DarkTable/darktable/src/control/control.c:955
    #10 0x00007ffff7c2974a in dt_control_work (ptr=0x66e290) at /home/jp/DarkTable/darktable/src/control/control.c:1153
    #11 0x0000003b6ea07d90 in start_thread () from /lib64/libpthread.so.0
    #12 0x0000003b6def119d in clone () from /lib64/libc.so.6

darktable: master @ 684370a2bc2e1ce1939f97f1054ec712bedc6b47 (September 29, 2012)

Likely a double free.

Associated revisions

Revision 0bde94f4 (diff)
Added by Tobias Ellinghaus over 7 years ago

Don't expand variables before setting the params

This should fix #8958. I am not quite sure what the code which I removed
was supposed to do, so it's quite possible that I changed the behaviour
of darktable somehow. At least the new behaviour no longer includes
crashing, so it shouldn't be too bad. :)

History

#1 Updated by Jesper Pedersen over 7 years ago

0x00007ffff7c1a4bc in dt_variables_expand (params=0x7fffe8011750, string=0x7fffe8001130 "h\006", iterate=1)
at /home/jp/DarkTable/darktable/src/common/variables.c:261
261 if( params->data->result )

#2 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 20
  • Target version set to Candidate for next minor release
  • Priority changed from High to Medium
  • Status changed from New to Triaged

Confirmed

#3 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:0bde94f4b5236f004553c64c6bd4aa97c1342ec2.

Also available in: Atom PDF

Go to top