Project

General

Profile

Bug #8921

crop and rotate module doesn't work well with orientation module

Added by Igor Kuzmin almost 7 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
-
Start date:
09/09/2012
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

there are at least 2 issues:
1). enable orientation module - rotate an image once in any direction (so image becomes portrait if it was landscape and vice versa)
2). enable crop and rotate and try adjusting crop area - you will see first bug, crop&rotate is confused about photo's actual current orientation
3). apply some crop
4). go back to orientation module and rotate image again
5). you will see second bug - crop area doesn't rotate with the image, so different part of image now will be seen


Related issues

Duplicated by darktable - Bug #9334: Incorrect interaction between "orientation" and "crop and rotate: keystone" modules Confirmed 04/02/2013

History

#1 Updated by Markus Jung almost 7 years ago

@5: This is a topic i brought up on the mailinglist about a year ago. While i think this behaviour is confusing and misleading, the answer has been: rotate first and crop later. Rotating causes also worse side effects for vignetting (#8560) ...

#2 Updated by Igor Kuzmin almost 7 years ago

Well, OK, that makes sense, but it still leaves first issue.

#3 Updated by Tobias Ellinghaus almost 7 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

Maybe we should go back to having all these functionalities in a single module ...

#4 Updated by Igor Kuzmin over 6 years ago

  • System set to all

another example of this issue: #9334 (closed it as a duplicate of this bug)

#5 Updated by Roman Lebedev about 5 years ago

  • bitness set to 64-bit

First bug ( 1). and 2). ) is fixed.

#6 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed
  • Assignee set to Roman Lebedev

Bug (1) was finally fully fixed by 628267a12d46519b336798be14e1d09dd47801b1
As for (2), i will close this as fixed and reopen #9334. (several issues in one redmine issue is not cool :)

Also available in: Atom PDF