Project

General

Profile

Feature #8868

Darktable should read embedded color profiles from JPGs

Added by Andreas Siegert over 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
08/20/2012
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Darktable messes up images with custom color profiles, see
http://www.fotocommunity-prints.de/fileadmin/daten/farbkreis.jpg
(color names are in German, the top should be red)

(tested on 1.0.5 from Pascals PPA).

Associated revisions

Revision 0ad62ef2
Added by Tobias Ellinghaus over 5 years ago

Fix #8868: Read embedded color profiles from JPEGs

This needs some polishing due to bugs that affect other parts, too
(missing gui updates) but in general it works.

History

#1 Updated by Tobias Ellinghaus over 5 years ago

  • Tracker changed from Bug to Feature
  • % Done changed from 0 to 20
  • Target version set to Future
  • Status changed from New to Triaged
  • Category set to Darkroom

darktable doesn't read embedded color profiles on purpose. I changed this to a feature request, maybe someone is interested in writing code for this.

#2 Updated by Pascal de Bruijn over 5 years ago

  • % Done changed from 20 to 0
  • Status changed from Triaged to New
  • Category deleted (Darkroom)
  • Subject changed from JPGs with embedded color profiles are not rendered correctly to Darktable should read embedded color profiles from JPGs
  • Target version deleted (Future)

Darktable is very RAW oriented.

Our JPEG (and other formats) reading implementation have some known limitations. Not reading embedded color profiles is one of them.

We supply our owns version of sRGB and AdobeRGB which can be selected from the 'input color profile' plugin, to compensate for this (to an extent).

If you're using more exotic profiles, you can put whatever profile you need in ~/.config/darktable/color/in (and restart darktable) after which it becomes available for selection in the 'input color profile' plugin.

#3 Updated by Pascal de Bruijn over 5 years ago

  • Target version set to Future
  • Category set to Darkroom

#4 Updated by Pascal de Bruijn over 5 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

#5 Updated by Andreas Schrell over 5 years ago

Oh no thats really a bug, not a feature request.

#6 Updated by Tobias Ellinghaus over 5 years ago

Since darktable's primary focus are RAW files and reading JPEGs is just a convenience feature this is not a bug. And I guess hardly any developer opens JPEG files in darktable, so it could take quite some time until this ticket can be closed. Sorry for that.

#7 Updated by Andreas Siegert over 5 years ago

Why bother with rendered files at all?
The current implementation is basically useless and shows that they guys who implemented it did not really think it through. Taking the profile from the rendered file would have been trivial.
Better block the rendered files instead of giving the user false hopes.

And yes, there are plenty of reasons why one would want to use one tool for both raw and rendered files. workflow consistency and ease of use for example.

#8 Updated by Tobias Ellinghaus over 5 years ago

That's great news! We will gladly accept any trivial patch to enable darktable to read the embedded profiles of JPEG images. Thanks in advance!

#9 Updated by Tobias Ellinghaus over 5 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:0ad62ef29e3f4aa76d56f485e6cca569e517248d.

Also available in: Atom PDF