Project

General

Profile

Bug #8867

cacorrect fails when rawdenoise is enabled

Added by Zeus Panchenko over 6 years ago.

Status:
Fixed
Priority:
Medium
Category:
Darkroom
Start date:
08/20/2012
Due date:
% Done:

100%

Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

History

#1 Updated by Pascal de Bruijn over 6 years ago

  • Status changed from New to Closed: invalid

With that sample CR2, I have no CA to begin with. So I'm not sure where those artifacts came from (tested with 1.0+1200~g3626b6e).

#2 Updated by Pascal de Bruijn over 6 years ago

  • % Done changed from 0 to 100
  • Target version set to Candidate for next major release
  • Status changed from Closed: invalid to Fixed

We briefly spoke on IRC:
17:41 < z_eos> pmjdebruijn: try to switch on both plugins

So I did some more experimentation, and I could reproduce.

So it seems rawdenoise is making cacorrect go completely bonkers, where it's actually overcorrecting ca, so it's essentially adding reverse ca :(

This should be fixed now:
https://github.com/darktable-org/darktable/commit/128e0564e72ccd9fa297c684701c45bb6a81d126

Also available in: Atom PDF