Project

General

Profile

Bug #8846

sqlite error with selection of film roll

Added by James C. McPherson over 7 years ago.

Status:
Fixed
Priority:
Low
Category:
General
Start date:
08/01/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

If you select some images from your collection, and then use the 'select film roll' button from the Selection plugin, you will
see this warning (either in your terminal session or $HOME/.xsession-errors):

sqlite3 error: /scratch/src/photostuff/darktable/fromgit/dc0df1bdd1360481ec4514f41e81c6eaf773244b/src/common/selection.c:249,
function dt_selection_select_filmroll(): temporary table name must be unqualified

This comes from src/common/selection.c::

245 void dt_selection_select_filmroll(dt_selection_t *selection)
246 {
247 DT_DEBUG_SQLITE3_EXEC(dt_database_get(darktable.db),
248 "create temp table memory.tmp_selection (imgid integer)",
249 NULL, NULL, NULL);

There are two problems here. Firstly, the table name is qualified (memory.tmp_selection) when it should not be, given the TEMP
attribute. Secondly, we're creating this table every time we enter this callback.

0001-fixes-8846.patch (8.98 KB) 0001-fixes-8846.patch James C. McPherson, 08/01/2012 01:02 AM
0001-fixes-8846.patch (1.78 KB) 0001-fixes-8846.patch James C. McPherson, 08/01/2012 01:52 AM

Associated revisions

History

#1 Updated by James C. McPherson over 7 years ago

Fix is to remove the 'create temp table' from selection.c. We already have a memory.tmp_selection table created via src/control/control.c at startup.

#2 Updated by James C. McPherson over 7 years ago

Updated patch to remove unnecessary whitespace changes.

#3 Updated by James C. McPherson over 7 years ago

  • % Done changed from 70 to 100
  • Status changed from Patch attached to Fixed

Applied in changeset darktable|commit:cc37f2e6f850d75eda6e31490860e23783aa4df3.

Also available in: Atom PDF

Go to top