Project

General

Profile

Bug #8775

Changes in default tags on import in preferences are not saved

Added by Richard Wonka over 7 years ago.

Status:
Fixed
Priority:
Low
Category:
Lighttable
Start date:
06/13/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When I try to change which tags get attached to images on import, the change is not saved.

I have a list of three of my more common tags there (not sure where they came from) and am trying to remove one of them, but to no avail.

  1. open preferences
  2. default tags are "Phuket, Eco Café, Thailand"
  3. change them to "Phuket, Thailand"
  4. close preferences
  5. open preferences again
  6. default tags are "Phuket, Eco Café, Thailand"

Associated revisions

Revision 9c5eefbf (diff)
Added by Tobias Ellinghaus over 7 years ago

Fix #8775: Apply pref changes when dialog is closed

History

#1 Updated by Tobias Ellinghaus over 7 years ago

  • Target version set to Candidate for next minor release
  • Assignee set to Tobias Ellinghaus
  • Status changed from New to In Progress

#2 Updated by Tobias Ellinghaus over 7 years ago

  • Status changed from In Progress to Triaged

This is what happens: you have to confirm your changes by pressing enter to get saved. That's the same with all the settings. I just tried to find a way to make settings update when the preferences window is closed but had no luck (I don't get any signal when the window is closed).

So I can either leave this ticket open until someone finds a way to execute code when the window is closed, or I can mark this as invalid since it's not really a bug. Not sure what to do.

Setting back to Triaged for the time being.

#3 Updated by Richard Wonka over 7 years ago

How about adding an [OK] button that saves and closes?

#4 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:9c5eefbfe293fa094a347ab8ed2f89df656a64c0.

Also available in: Atom PDF

Go to top