Project

General

Profile

Bug #8772

Tagging, rating, etc.. work on the image hovered over, even when images are selected in lighttable

Added by Richard Wonka over 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Medium
Assignee:
-
Category:
Lighttable
Start date:
06/12/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

tagging, rating and metadata work only on the image currently hovered above, even if one or more images are selected.

Hovering itself has good use cases for pointer users, but selections are currently essentially ignored by these modules. When I have selected a number of images and add a tag, I expect all selected images to be tagged, not the one that the mouse pointer hovered over last - which might even not be in the selection.

To minimise surprises, hover-mode could be switched off as soon as there is a selection of one or more images and then any actions act on the selection instead of the image hovered above.

This will allow hover mode to be used and fix the selections bug.


Related issues

Has duplicate darktable - Bug #8687: lightroom - continuous image selection (SHIFT key) - first image is unstarredDuplicate

Has duplicate darktable - Bug #8815: focus/hovering in lightable is defective/inconsistentDuplicate07/05/2012

Associated revisions

Revision 92161f62 (diff)
Added by Tobias Ellinghaus over 7 years ago

Ticket #8772: remove hover when leaving to left

Revision b96be880 (diff)
Added by Tobias Ellinghaus over 7 years ago

Ticket #8772: remove hover when leaving to left

Revision f81aa267 (diff)
Added by Jose Carlos Garcia Sogo almost 7 years ago

If zoom==1, apply metadata only to visible image, if not, to selection. Fixes #8772

Revision fc263811 (diff)
Added by Jose Carlos Garcia Sogo almost 7 years ago

If zoom==1, apply metadata only to visible image, if not, to selection. Fixes #8772

History

#1 Updated by Richard Wonka over 7 years ago

I am assigning this a high priority because it violates one of the most basic paradigms of user interfaces: Actions work on selected items. - Just imagine your file manager were to behave like this and delete not the selection, but the file you happened to hover over.

This unexpected behaviour affects a vast majority of all users that try darktable.

#2 Updated by Simon Spannagel over 7 years ago

  • Target version set to Candidate for next minor release

I agree this is something to be changed.

But since this will change the workflow of quite some people it might be best to discuss this a bit more with some devs on IRC.

#3 Updated by Ivan Tarozzi over 7 years ago

  • Target version deleted (Candidate for next minor release)

Richard Wonka wrote:

tagging, rating and metadata work only on the image currently hovered above, even if one or more images are selected.

Hovering itself has good use cases for pointer users, but selections are currently essentially ignored by these modules. When I have selected a number of images and add a tag, I expect all selected images to be tagged, not the one that the mouse pointer hovered over last - which might even not be in the selection.

+1

I also notice a strange behavior: if I move mouse to right panel, hovered image is "unselected" but if I move to left panel the last hovered image near the border remain "selected" (light-gray)
This increase confusion.

So, if I selected images (click - shift/ctrl-click) and I move to left panel and apply rating or color label, these are applied to all selected images.

If I move to right panel and/or use the same rating/color then only last hovered image is affected.

Tags seems works better, because applied to selected images. Only if I use ctrl-t smart tagging it works on hovered image only (I would prefer use it on all selected images instead).

To minimise surprises, hover-mode could be switched off as soon as there is a selection of one or more images and then any actions act on the selection instead of the image hovered above.

ok, I agree; but what show in tag list? Only common tags applied to all selected images? nothing?

This will allow hover mode to be used and fix the selections bug.

I think this issue could open discussion about all lighttable management, talking about to keyboard movement and selections too :)

#4 Updated by Simon Spannagel over 7 years ago

  • Target version set to Candidate for next minor release

#5 Updated by Richard Wonka over 7 years ago

So, if I selected images (click - shift/ctrl-click) and I move to left panel and apply rating or color label, these are applied to all selected images.

If I move to right panel and/or use the same rating/color then only last hovered image is affected.

That sounds like it should really get into one of the next minor releases.

Tags seems works better, because applied to selected images. Only if I use ctrl-t smart tagging it works on hovered image only (I would prefer use it on all selected images instead).

That's what triggered this bug. I tried to tag several images using [ctrl]+t but only one ever got tagged.

ok, I agree; but what show in tag list? Only common tags applied to all selected images? nothing?

For Metadata:
  • If the values for a field (e.g. publisher) is the same in the entire selection, then it's easy: show what is there.
  • If there are different values, show a greyed-out text saying something like <different entries> and allow a selection of one via the drop down list next to the text field.
For Tags:
  • Show the ones present in all images in normal font colour and a remove button [x] next to each
  • Show the ones present in only some images greyed out and show a remove button and an [apply to all] button (e.g. a tick mark) next to each.

I think this issue could open discussion about all lighttable management, talking about to keyboard movement and selections too :)

I've already seen bits of that discussion - and filed a bug report. Keybard selection of images seems virtually impossible unless one uses [Alt]+1 and [Tab]. #8716 is the related issue. :-)

#6 Updated by Simon Spannagel over 7 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged

#7 Updated by Richard Wonka over 7 years ago

Has there been enough discussion about this? After using dt for some time, I find the entire hovering functionality only adds randomness in ambiguity at next to no benefit.

Please switch hovering off - I know that my system will even be more responsive then, as the hover-highlight often takes some time to follow the mouse pointer in lighttable - and it is only possible to select an image when the image has the hover-highlight.

It's a bit of a pain, really..

#8 Updated by Tobias Ellinghaus over 7 years ago

  • Priority changed from High to Medium
  • Status changed from Triaged to Incomplete

If I didn't miss anything it's no longer possible to click buttons while images are being hovered. So the only occurrence of this bug is when you use shortcuts. Can you confirm that?

Setting priority to Medium.

#9 Updated by Ivan Tarozzi over 7 years ago

Here my feeback (based on today git version):

- now, when move cursor to left panel, images are not hovered : now is ok
- when I select multiple images and use Tag panel or button for color labels and stars, I apply to all selected images
- when I select multiple images ad I use shortcut without hovering pictures (mouse on side panels) I apply to all selected images.
- when I select multiple images ad I use shortcut hovering pictures (mouse on picture), stars and color labels are applied to hovered image only
- but in last scenario, if I use ctrl-t to assing tag, tag is applied to all selected images, not only to hovered picture.

So imo the problem is to treat last 2 points in the same way.

I prefer assign shortcut property to all selected images, independently of hovered image. So the ctrl-t behavior is correct for me. The same should be for color and stars.

If I want to assign star/color-label using mouse+shortcut hovering images (I use this way a lot for my first check to evaluate/reject) simply I will have to unselect multiple images first.

#10 Updated by Tobias Ellinghaus over 7 years ago

  • Status changed from Incomplete to Triaged

The last one got fixed in 2465279ad95e2de705ab627b6d79f198cfe6caf3 and this is how it should behave for all shortcuts. So I was right that the only misbehaving parts are the shortcuts, button clicks work as intended. :D

#11 Updated by Jose Carlos Garcia Sogo almost 7 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Applied in changeset darktable|commit:f81aa267329e081b442936fd5032d87011edd3b1.

Also available in: Atom PDF

Go to top