Project

General

Profile

Bug #8770

Bad grammar in empty collection screen

Added by Richard Wonka over 7 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Lighttable
Start date:
06/12/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
1.0.4
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

The text in the empty collection screen has some colloquial wording with bad grammar.

I am currently fixing that in a topic branch.

Associated revisions

Revision 9b6dc88e (diff)
Added by Richard Wonka over 7 years ago

Wording for bugs #8771, #8770 and eye candy

History

#1 Updated by Simon Spannagel over 7 years ago

  • Target version set to Candidate for next patch release
  • Status changed from New to In Progress

:)
so setting to "in progress"?

#2 Updated by Richard Wonka over 7 years ago

thanks for changing the status. I wasn't able to set it to "In Progress"

I have sent a pull request for this, but am not sure if I did it right.. my topic branch for this is called wording

#3 Updated by Jérémy Rosen over 7 years ago

  • Status changed from In Progress to Patch attached

#4 Updated by Richard Wonka over 7 years ago

I have closed the above pull request, cleaned up my wording branch to just contain the relevant changes and issued a new request: https://github.com/darktable-org/darktable/pull/20

I hope you like the eye candy I've put into the filter. It looks really nice in the gui.

sorry for the inconvenience.

#5 Updated by Simon Spannagel over 7 years ago

  • Status changed from Patch attached to Fixed: To be cherry-picked

Closing this issue since Richard's commit has been merged into git master (9b6dc88e)
Marking for possible cherry-pick to stable branch.

#6 Updated by Jérémy Rosen over 7 years ago

  • Status changed from Fixed: To be cherry-picked to Fixed

Also available in: Atom PDF

Go to top