Project

General

Profile

Bug #8740

Baby steps: fixed some wording and added option "-h" to darktable.c

Added by Richard Wonka about 8 years ago.

Status:
Closed: won't fix
Priority:
Low
Assignee:
-
Category:
General
Start date:
06/03/2012
Due date:
% Done:

0%

Estimated time:
Affected Version:
git development version
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Not knowing how else to do this, here is a patch.

patch for -h and wording.diff (923 Bytes) patch for -h and wording.diff Richard Wonka, 06/03/2012 04:03 AM

History

#1 Updated by Jérémy Rosen about 8 years ago

hmm, that's a very small patch, I can apply it but if you plan to do lots of tiny steps like that it might be more handy to do a fork on github and have us apply the whole branch...

your call....

#2 Updated by Richard Wonka about 8 years ago

I know it's a very small patch. It's more about finding out how things work, as this is the first time I'm working in an environment like this. :-)

A branch sounds more reasonable, then. That's exactly what I wanted to know. I've read git tutorials and am using it on my own, but might come up with the occasional "how do I go about this..." question.

You can leave this patch and I'll branch out. Are there any best practices to naming a branch?

#3 Updated by Simon Spannagel about 8 years ago

  • Target version set to Candidate for next minor release

If you need any help concerning the workflow just bump us.
:)

Name the branch as you like...

#4 Updated by Jérémy Rosen about 8 years ago

  • Affected Version set to git development version
  • Status changed from New to Closed: won't fix

I mark the patch as won't fix since you will do a pull request through github... the patch itself is good

Cheers
Boucman

#5 Updated by Tobias Ellinghaus about 8 years ago

Even though this ticked is closed by now I'd still like to remark that the patch (well, the content) is not good: it uses tabs instead of spaces for indentation. No big issue, just wanted to tell the world about it. :)

#6 Updated by Richard Wonka about 8 years ago

Aahh, I saw that, but - mea culpa - didn't change it. I'll tell vim about it. :-) (sw=2, right?)

I'll try to emulate what code is already there. Is there a DT coding style guide?

#7 Updated by Tobias Ellinghaus about 8 years ago

Yes, there is "mimic whatever you find in the file you edit". :D

It's mostly just "use 2 spaces for indentation" and in most files the {} are on their own line. The rest (like: spaces before '(') can be done to your liking. Just make sure it's readable.

#8 Updated by Jérémy Rosen about 8 years ago

please check

tools / beautify_style.sh

it's a tool to adjust the style, I guess its a sor of reference to the
style we want (we han't run it for a long time... maybe we should)

#9 Updated by Simon Spannagel almost 8 years ago

  • Tracker changed from 4 to Bug

Also available in: Atom PDF

Go to top