Project

General

Profile

Feature #8731

Merge "keywords" and "tagging" modules

Added by Edgar Scholz over 5 years ago. Updated over 5 years ago.

Status:
Triaged
Priority:
Low
Assignee:
-
Category:
Lighttable
Target version:
Start date:
06/05/2012
Due date:
% Done:

20%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi

In my eyes, the tagging-module is a bit confusing. If I use more than 10 tags, I loose trac of what I am doing.

It would be great, if the tagging-module look similar to the keywords-module in its well-structured and ordered way. And I would like to use the mouse on this stucture. For example:
Right-click on an existing tag opens a text-field, where I can type the name of the sub-tag. (That would be a little bit like tagging in digikam)

Edgar

dt3.jpg (54.8 KB) Edgar Scholz, 06/04/2012 11:18 PM


Subtasks

Bug #8750: Select first keyword suggestion with single down arrow (instead of 2) Triaged


Related issues

Related to darktable - Feature #8661: Tags and Keywords offer redundant functionality Triaged

History

#1 Updated by Simon Spannagel over 5 years ago

  • Target version set to Candidate for next minor release

Hi Edgar,

this is a good observation and, indeed, those modules are going to be merged in the near future. They both provide some redundant functionality and are related to tagging of images. Even though nobody is actually working on this right now we want to merge them soon.

If you have some creative ideas how a optimal UI for a combined tagging&keyword module could look like, you're very welcome to share this idea with us...

regards,
Simon

#2 Updated by Simon Spannagel over 5 years ago

  • Subject changed from tagging improovement to Merge "keywords" and "tagging" modules

#3 Updated by Edgar Scholz over 5 years ago

I played a little bit with gimp 2.8. Nice tool ;) Look, what I´ve done with the keywords-module. And see my thoughts, how it could work:

First I select a keyword with my mouse, in this case it is "darktable". Now the buttons should affect this:

new
The selected keyword "darktable" is the parent-keyword. In the field below I can type a new keyword as child. So the result would be in this case: darktable|new keyword.

change
The selected keyword "darktable" can be changed. I can make this change in the field below. For example I can change "darktable" to "lighttable". All pictures with the keyword should be affected by this chance. Example: "darktable|format|cr2" goes to "lighttable|format|cr2" in this case.

apply
the selected keyword is applied to all selected pictures.

deleate
The selected keyword will be deleated. This keyword should be remooved from all pictures, containing it. A popup-field should appear and ask: Shall the child-keywords be deleated, too? Or where shall they be mooved to?

Some thougts to the selection of the keywords.

I can select a keyword with the mouse (left-click). Selecting another keyword should not result in collecting this new keyword and the old keyword with a logical AND (that´s the actual behavior). Selecting another keyword should reset the old filter-rule and only filter pictures, containing this new keyword.

Edgar

#4 Updated by Ivan Tarozzi over 5 years ago

Edgar Scholz wrote:

I played a little bit with gimp 2.8. Nice tool ;) Look, what I´ve done with the keywords-module. And see my thoughts, how it could work:

Here just my 2 cents ;)

First I select a keyword with my mouse, in this case it is "darktable". Now the buttons should affect this:

new
The selected keyword "darktable" is the parent-keyword. In the field below I can type a new keyword as child. So the result would be in this case: darktable|new keyword.

How to create a root level tag? What about right-click on tag tree and adding a popup menu with :
- New root tag
- New child tag
- Rename tag
- Delete tag

change
The selected keyword "darktable" can be changed. I can make this change in the field below. For example I can change "darktable" to "lighttable". All pictures with the keyword should be affected by this chance. Example: "darktable|format|cr2" goes to "lighttable|format|cr2" in this case.

+1

apply
the selected keyword is applied to all selected pictures.

I found useful also to maintain actual ctrl-t mode, extending it to "all selected inages" and not only mouse hovered image. I'm a fan of keyboard :)

We probably need also to review how assigned tag are displayed. I don't like lightroom mode (sign in tag tree) but I prefer a list (may be hierarchical formatted) of only assigned tags.

A solution could be: move keyword module to right panel (where there are other modules to assign metadata ...) and add assigned tag list in "image information" module (into or after it).

deleate
The selected keyword will be deleated. This keyword should be remooved from all pictures, containing it. A popup-field should appear and ask: Shall the child-keywords be deleated, too? Or where shall they be mooved to?

ok for this! but we need also a command to unapply tag without delete it. So other button or other popup menu item.

Some thougts to the selection of the keywords.

I can select a keyword with the mouse (left-click). Selecting another keyword should not result in collecting this new keyword and the old keyword with a logical AND (that´s the actual behavior). Selecting another keyword should reset the old filter-rule and only filter pictures, containing this new keyword.

Partially agree :)
I don't like too actual behavior that ADD rule to filter, but I don't like to erase all current filter.
For example, if my current filter is Italy AND Rome and I want to see Italy AND Venice, a solution could be:

- double-click on Rome tag remove this tag from filter
- double-click on Venice tag add this to filter

So: if tag is already in collect filter it remove, else add as AND

Ivan

PS:
is this the right place to continue this interesting discussion? how mailing list (dev and user) could be involved? I think a user's feedback could be useful... and developer too, of course ;)

#5 Updated by Simon Spannagel over 5 years ago

Ivan Tarozzi wrote:

PS:
is this the right place to continue this interesting discussion? how mailing list (dev and user) could be involved? I think a user's feedback could be useful... and developer too, of course ;)

I hope they will follow here...
We wanted the tracker to disburden the mailing list a bit. Maybe we can push to ml if nobody else participates in the discussion.

#6 Updated by Richard Wonka over 5 years ago

#8661 is a related issue.

#7 Updated by Richard Wonka over 5 years ago

How about this view of things:

The current tagging module is used to assign tags, while the current keywords module is used to filter for tags.

Filtering is something that is mostly done in the collections module, so the keywords module could be removed and its functionality be moved into the collections module (which does this anyway), so the keywords modules is redundant anyway. The keywords tree could appear in the collections module when filtering for tags instead of the list of tags with their visible "|"s

Thus we would have
  • a cleaner UI with one less module and less redundant functionality
  • gotten rid of the the word "keywords" and unified to "tags", which is common usage for this
  • moved this filtering functionality where (most of) the filtering happens

#8 Updated by Ivan Tarozzi over 5 years ago

I think this could be a good starting point to review tagging system.

Then I think could be useful to complete keyboard tagging (ctrl-t) for all selected images. I like this more than drag-and-drop mentioned in other documents.

I think this review and ligthtable revamping (scroll, move, select with keyboard) are related and should be better to find a global solution, but because decision are freezed from some month, I vote to start and go step by step :)

#9 Updated by Tobias Ellinghaus over 5 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Triaged
  • Target version changed from Candidate for next minor release to Future
  • Category set to Lighttable

Also available in: Atom PDF