Project

General

Profile

Bug #8710

keywords module doesn't refresh list on tag table changes

Added by Simon Spannagel over 7 years ago.

Status:
Fixed
Priority:
Low
Category:
Lighttable
Start date:
05/30/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
1.1.1
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

[manually copied from Trac]

As reported on the mailing list, if you add/delete/change a tag, that change is not
reflected in the Keywords module until you restart the application.

Root cause appears to be that we only query the tags table for new tags on startup,
rather than when we update().

History

#1 Updated by Simon Spannagel over 7 years ago

  • Category changed from General to Lighttable

For me it used to work when changing view (so go to darkroom and back to lighttable), I can't check right now but the code looks unchanged.

Updating it with new tags added would be a major improvement though... :)

#2 Updated by Simon Spannagel over 7 years ago

  • Affected Version set to 1.0.4

#3 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 20
  • Status changed from New to Incomplete

Does this still happen?

#4 Updated by Tobias Ellinghaus about 7 years ago

  • Affected Version changed from 1.0.4 to 1.1.1
  • % Done changed from 20 to 10
  • Status changed from Incomplete to Confirmed

It was just confirmed in IRC for 1.1.1

#5 Updated by Ivan Tarozzi about 7 years ago

Are you sure is this confirmed?

I done a patch and pull request some time ago, and it seems merged in the commt:
7adb85a009a850ca44ee3f19998ae68b141d85bf

#6 Updated by Tobias Ellinghaus about 7 years ago

  • % Done changed from 10 to 100
  • Status changed from Confirmed to Fixed

I set it to Confirmed for 1.1.1. Since it's fixed in git (no idea about 1.1.2) I'm closing. Thanks everyone.

Also available in: Atom PDF

Go to top