Project

General

Profile

Bug #8704

segfault while exporting re-imported picture with no history stack

Added by Igor Kuzmin over 7 years ago. Updated about 6 years ago.

Status:
Fixed
Priority:
Critical
Assignee:
-
Category:
-
Start date:
05/29/2012
Due date:
% Done:

100%

Estimated time:
Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I use git master, more precisely this bug present on ebd2d5a86a967bef7f04602c42a3700e4c73ccbb

Steps to reproduce:
  1. copy some raw file to a folder of an existing filmroll (new one probably will do too)
  2. start darktable and reimport that folder
  3. after new image appears, open it in darkroom mode, then switch back to lighttable
  4. remove this image from filmroll
  5. again reimport that folder and wait for image to reappear
  6. try to export it

Result will be segfault in process function of WB plugin. Backtrace is attached (both for OpenMP enabled and disabled builds). I investigated a bit and found that the underlying problem is temperature plugin thinking that it processes already demosaiced data and so going outside the input buffer:

(gdb) print piece->pipe->image
$10 = {exif_inited = 1, orientation = 0, exif_exposure = 0.00200000009, exif_aperture = 5.5999999, 
  exif_iso = 200, exif_focal_length = 35, exif_focus_distance = 0, exif_crop = 0, 
  exif_maker = "Canon", '\000' <repeats 26 times>, exif_model = "Canon EOS 7D", '\000' <repeats 19 times>, 
  exif_lens = "Canon EF 35mm f/2", '\000' <repeats 34 times>, exif_datetime_taken = "2011:07:17 14:42:09", 
  filename = "IMG_3667.CR2", '\000' <repeats 243 times>, width = 0, height = 0, num = 0, flags = 1, 
  film_id = 31, id = 2775, dirty = 1, filters = 0, bpp = 2, legacy_flip = {legacy = 0, user_flip = 0}}

width, height and filters are zero, while they shouldn't be.
I didn't disable the usage of embedded preview jpegs, which could be relevant.

dtbt (66.7 KB) dtbt backtrace with OpenMP enabled Igor Kuzmin, 05/29/2012 04:30 PM
dtbt-noopenmp (64.2 KB) dtbt-noopenmp backtrace wiith OpenMP disabled Igor Kuzmin, 05/29/2012 04:30 PM

History

#1 Updated by Simon Spannagel over 7 years ago

  • Description updated (diff)

#2 Updated by Igor Kuzmin over 7 years ago

  • Affected Version set to git development version

Actually right now just reimporting by itself causes a crash or/and corrupted thumbnail (and crash on entering darkroom) for me both on Linux and OS X. Maybe related to the fact that I switched on the option to use half-sized raw for thumbnail generating. Smth is very broken here.

#3 Updated by Tobias Ellinghaus over 7 years ago

  • % Done changed from 0 to 20
  • Target version set to Candidate for next minor release
  • Priority changed from Low to Critical
  • Status changed from New to Triaged

Confirmed.

#4 Updated by Christian iuga about 6 years ago

i just try to reproduce, but i can't confirm it, can you retry again with a recent git version ?

#5 Updated by Pascal Obry about 6 years ago

  • bitness set to 64-bit
  • System set to all

Most probably duplicate with #9713.

#6 Updated by Pascal Obry about 6 years ago

  • % Done changed from 20 to 100
  • Status changed from Triaged to Fixed

Cannot reproduce anymore. Let's pretend it is fixed by #9713.

Also available in: Atom PDF

Go to top