Project

General

Profile

Feature #8659

Enable lensfun by default without overriding exif values

Added by cebewee - over 6 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

For some lenses it is desirable to always enable the lensfun module. Darktable lacks a convenient way to enable the lensfun module while keeping the settings derived from exif data (focal length, aperture, ...).

When presets or styles are used to enable the lensfun module, then also the values for focal length etc. are overriden with fixed values.

A possible solution would be to extend the lensfun module with a "use exif data"-switch, which would disable the manual settings.


Related issues

Duplicated by darktable - Bug #8874: style with lens correction saves all values, even for zoom lenses Duplicate 08/21/2012

History

#1 Updated by Tobias Ellinghaus about 6 years ago

  • % Done changed from 0 to 20
  • Category changed from General to Darkroom
  • Status changed from New to Triaged
  • Target version changed from --- to Future

#2 Updated by Ralf Brown over 4 years ago

I got bitten by the preset-overrides-ExIF too. Oddly enough, the Profiled Denoise module doesn't suffer from this problem....

#3 Updated by Jérémy Rosen over 4 years ago

  • Status changed from Triaged to Patch attached
  • % Done changed from 20 to 70

#4 Updated by Roman Lebedev over 4 years ago

  • % Done changed from 70 to 100
  • Status changed from Patch attached to Fixed
  • Assignee set to Roman Lebedev

I merged my, earlier vesrion PR 548 in 8b1fc5977cc68ebbfebe951f95b3825ac23fe339
Maybe some time later i'll rewrite it to be more configurable, but not now.

Also available in: Atom PDF