Project

General

Profile

Feature #8531

Patches for building on OS X 10.6.7 (GCC 4.6.1)

Added by jhegeman - about 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Low
Category:
General
Target version:
Start date:
Due date:
% Done:

100%

Affected Version:
System:
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Dear all,

Thanks to some hints I received on the mailing list, and some study of the code, I managed to compile everything (from Git: accels-premerge-66-g03ff440) on my Mac running OS X 10.6.7. I am opening this ticket as a place to put all the patches I applied and as a point for further discussion. Below are the steps I followed.

All of the attached patches look like they should be pushed upstream, but since I'm a complete greenhorn coming to Darktable, I'm hoping that someone is willing to have a look at the below and test the resulting build first. (I know dt opens and I can play with it, but that's my current level of knowledge...)

Best regards,
Jeroen

--------------------------------------------------
Compiling Darktable 0.9 (from Git) on OS X 10.6.7
--------------------------------------------------

! Did this with GCC 4.6.1 installed via MacPorts !

With the below procedure everything compiles, also OpenCL and rawspeed.

- Install all dependencies via MacPorts.
- git clone git://darktable.git.sf.net/gitroot/darktable/darktable
- cd darktable
- for i in patch-*; do patch p0 < ${i}; done
./build.sh

Required patches:
- Fixes darktable/tools/create_metadata.sh.diff to replace 'echo n' by 'echo "somestring\c".'
patch-src-external-CL-cl.h.diff
A whole bunch of patches to RawSpeed to fix the precompiler directives. Basically just making APPLE equal to unix.
patch-src-rawspeed-RawSpeed-Camera.cpp.diff
patch-src-rawspeed-RawSpeed-CameraMetadataException.cpp.diff
patch-src-rawspeed-RawSpeed-Common.cpp.diff
patch-src-rawspeed-RawSpeed-Common.h.diff
patch-src-rawspeed-RawSpeed-FileReader.cpp.diff
patch-src-rawspeed-RawSpeed-OrfDecoder.cpp.diff
patch-src-rawspeed-RawSpeed-SrwDecoder.cpp.diff
patch-src-rawspeed-RawSpeed-StdAfx.h.diff
- Patch to OpenCL header file to properly treat OS X builds.
patch-src-external-CL-cl.h.diff
- Patch to include the OpenCL framework link instruction for highpass.
patch-src-external-CL-cl.h.diff

Notes:
- Something is still a bit fishy in the cmake setup, since I see lots of warnings ("ld: warning: duplicate dylib") about libraries being linked multiple times. I don't know anything near enough of cmake to fix this though.
- There are lots of compiler warnings for several pieces of code (mostly outside darktable itself) about unused variables, signed-vs-unsigned comparisons, etc.

History

#1 Updated by Henrik Andersson about 7 years ago

  • Status changed from New to In Progress

#2 Updated by jhegeman - about 7 years ago

Thanks Ulrich, I like your alternative fix to the OpenCL header patch. It works just fine.

So I think I'll now start moving the patches to RawSpeed upstream to RawStudio? The patches to iop and tools are Darktable-internal, right?

Jeroen

#3 Updated by Henrik Andersson about 7 years ago

Yeap, rawspeed patches should go upstream, Klaus will be thankful for that..

the rest is internals, and ill review them in an hour or soo..

Regards,

Henrik

#4 Updated by Henrik Andersson almost 7 years ago

Created a bug upstream for rawspeed patches:

http://bugzilla.rawstudio.org/show_bug.cgi?id=514

Referenced back to this ticket.

#5 Updated by Henrik Andersson almost 7 years ago

patches has now been applied upstream for rawspeed project...

#6 Updated by Simon Spannagel about 6 years ago

  • Status changed from New to Fixed

Also available in: Atom PDF