Project

General

Profile

Bug #8493

Lens correction defaults to rectilinear output type no matter what is the actual input type

Added by milan_knizek - about 8 years ago. Updated over 4 years ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
General
Start date:
Due date:
% Done:

100%

Affected Version:
git development version
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Lens correction defaults to rectilinear output type no matter what is the actual input type.
E.g. if the lens is a fisheye, dt converts the geometry to rectilinear, which is probably an unwanted default behaviour.

dt should set the output type to the same value as is the input type.

Lens correction plugin takes the lens information from lensfun database. Lensfun distinguishes the following types:

<type>string</type> Lens type. This is one of: "rectilinear", "fisheye", "panoramic", "equirectangular".


Related issues

Related to darktable - Feature #8633: Darkroom, lens correction plugin Fixed

Associated revisions

Revision f5185892
Added by Roman Lebedev over 4 years ago

Lens IOP: default geometry to input lens type. Fixes #8493

History

#1 Updated by Simon Spannagel about 7 years ago

confirmed for version 1.0

#2 Updated by Simon Spannagel almost 7 years ago

  • Target version changed from 1.0.3 to Candidate for next patch release

#3 Updated by Simon Spannagel almost 7 years ago

  • Affected Version set to git development version
  • Status changed from New to Triaged
  • % Done changed from 0 to 20

#4 Updated by Roman Lebedev over 4 years ago

  • Status changed from Triaged to Fixed
  • % Done changed from 20 to 100

#5 Updated by Roman Lebedev over 4 years ago

  • bitness set to 64-bit
  • Assignee set to Roman Lebedev
  • Target version changed from Candidate for next patch release to Candidate for next major release
  • System set to all

Also available in: Atom PDF