Project

General

Profile

Bug #12579

Cooy and paste history from one image to another clears source image's history

Added by Björn Sonnenschein 12 months ago. Updated 12 months ago.

Status:
Fixed
Priority:
Critical
Assignee:
Category:
Lighttable
Target version:
Start date:
02/01/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
other GNU/Linux
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Consider two images in the Lighttable A and B.
If adjustments of A are made in the Darkroom, and then in the Lighttable, one copies the history from A with CTRL+C and then pastes them on image B with CTRL+V,
the history is not applied to image B. Instead, image A's history is deleted.

Steps to reproduce:
1. Open some images in the Lighttable
2. Make adjustments to an image in the Darkroom
3. In the lightroom, copy the changes from the image with CTRL+C
4. Paste the changes to another image with CTRL+V

Associated revisions

Revision 23884b21 (diff)
Added by Pascal Obry 12 months ago

darkroom: unref current developped image when leaving the darkroom.

Fixes #12579.

Revision fc322e33 (diff)
Added by Pascal Obry 12 months ago

filmstrip: an image is opened in darkroom is we are not of lighttable.

This is a side effect of the filmstrip being activated in the lighttable
view for the exposé layout.

Also fixes #12579.

History

#1 Updated by Pascal Obry 12 months ago

Which is expected if you have the "overwrite" mode activated in the "history stack" module.

#2 Updated by Hans Bull 12 months ago

No it's the source image stack that gets zeroed...

Affects me too, git master branch

#3 Updated by Björn Sonnenschein 12 months ago

Yes, the source image's stack is deleted, and the history is not copied to the target image

#4 Updated by Pascal Obry 12 months ago

I can reproduce. Simpler:

- open a picture in darkroom
- back to lt
- ctrl+c

And the history of the image is deleted!

#5 Updated by Pascal Obry 12 months ago

  • % Done changed from 0 to 50
  • Target version set to Future
  • Priority changed from Low to Critical
  • Assignee set to Pascal Obry
  • Status changed from New to In Progress

#6 Updated by Pascal Obry 12 months ago

  • % Done changed from 50 to 100
  • Status changed from In Progress to Fixed

Should be fixed now.

Also available in: Atom PDF

Go to top