Filmic fails on first instance
Filmic iop gets crazy on its first run, when use "middle grey luminance eyedrop. To use that feature, you need to reset the filmic parameters by clicking on "reset parameters" after a first failure
#1 Updated by Pascal Obry 12 months ago
Can you test this?
#6 Updated by Paolo Astengo 12 months ago
Pascal, I'm afraid you are right.
Possibly I'm making some mistake trying to download and compile the source
git checkout fix-filmic-autotune-latitude
./build.sh --prefix /usr --buildtype Release --jobs 8 (I know I'm using /usr prefix, but I like to risk)
sudo cmake --build "/home/paolo/darktable/build" --target install -- -j8
What I'm missing?
I'm sorry for my poor knowledge of git system, but if you can help me, I guess I can learn how to contribute to the project
#8 Updated by Paolo Astengo 12 months ago
commit 4876ba7284fe7c20dc50e114231b4a2806964e5e (HEAD -> fix-filmic-autotune-latitude, origin/fix-filmic-autotune-latitude)
Author: Pascal Obry <firstname.lastname@example.org>
Date: Mon Jan 28 07:02:18 2019 +0100
filmic: ensure latitude_stops is initialized in auto-tune modes.
Otherwise any value will be set and sanitisation can go crazy and set
the latitude to zero leading to a B&W picture.
BTW, I tried a dirty way: I copied your filmic.c directly froy your PR to my src/iop directory and I compiled the sources.
No way, filmic still refuses to work (would you like me to test without opencl?)
#10 Updated by Paolo Astengo 12 months ago
Pascal Obry wrote:
Yes, you can test without OpenCL.
Filmic goes crazy even with OpenCL disabled.
Can you tell me if when it fails the latitude slider is 0 or very close?
Actually not. I'm following this way:
1. From lighttable select a fresh picture
2. In darkroom enable filmic
3. Press the eyedrop near "middle grey luminance"
At this point the curve starts to change for several times and it fails in a very strange condition (I'm attaching a screenshot)
4. Now if you reset the filmic parameters and repeat from point 3, the moule works as expected