Project

General

Profile

Bug #12570

Filmic fails on first instance

Added by Paolo Astengo 12 months ago. Updated 12 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
-
Start date:
01/27/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Filmic iop gets crazy on its first run, when use "middle grey luminance eyedrop. To use that feature, you need to reset the filmic parameters by clicking on "reset parameters" after a first failure

Schermata da 2019-01-28 18-49-52.png (40.3 KB) Schermata da 2019-01-28 18-49-52.png Crazy curve Paolo Astengo, 01/28/2019 07:52 PM

History

#2 Updated by Pascal Obry 12 months ago

  • Target version set to 2.6.1
  • Assignee set to Pascal Obry

#3 Updated by Paolo Astengo 12 months ago

Actually not, it doesn't solve it. It seems that there is something unitialized

#4 Updated by Pascal Obry 12 months ago

Strange I can reliably reproduce this issue without my patch and all is fine with it.

#5 Updated by Pascal Obry 12 months ago

And indeed, this is an unintialized variable. Have you properly build from my branch? The patch is not yet on master.

#6 Updated by Paolo Astengo 12 months ago

Pascal, I'm afraid you are right.

Possibly I'm making some mistake trying to download and compile the source

I'm doing:

git fetch
git checkout fix-filmic-autotune-latitude
git pull
./build.sh --prefix /usr --buildtype Release --jobs 8 (I know I'm using /usr prefix, but I like to risk)
sudo cmake --build "/home/paolo/darktable/build" --target install -- -j8

What I'm missing?

I'm sorry for my poor knowledge of git system, but if you can help me, I guess I can learn how to contribute to the project

#7 Updated by Pascal Obry 12 months ago

What says:

$ git log -1

?

#8 Updated by Paolo Astengo 12 months ago

commit 4876ba7284fe7c20dc50e114231b4a2806964e5e (HEAD -> fix-filmic-autotune-latitude, origin/fix-filmic-autotune-latitude)
Author: Pascal Obry <>
Date: Mon Jan 28 07:02:18 2019 +0100

filmic: ensure latitude_stops is initialized in auto-tune modes.
Otherwise any value will be set and sanitisation can go crazy and set
the latitude to zero leading to a B&W picture.

BTW, I tried a dirty way: I copied your filmic.c directly froy your PR to my src/iop directory and I compiled the sources.
No way, filmic still refuses to work (would you like me to test without opencl?)

#9 Updated by Pascal Obry 12 months ago

Yes, you can test without OpenCL. Can you tell me if when it fails the latitude slider is 0 or very close?

#10 Updated by Paolo Astengo 12 months ago

Pascal Obry wrote:

Yes, you can test without OpenCL.

Filmic goes crazy even with OpenCL disabled.

Can you tell me if when it fails the latitude slider is 0 or very close?

Actually not. I'm following this way:

1. From lighttable select a fresh picture
2. In darkroom enable filmic
3. Press the eyedrop near "middle grey luminance"

At this point the curve starts to change for several times and it fails in a very strange condition (I'm attaching a screenshot)

4. Now if you reset the filmic parameters and repeat from point 3, the moule works as expected

#11 Updated by Pascal Obry 12 months ago

I see, I have fixed the auto-tune but I can reproduce with the middle grey!

#12 Updated by Pascal Obry 12 months ago

Should be fixed now. Can you test master branch? Thanks.

#13 Updated by Paolo Astengo 12 months ago

Now it works perfectly, great!

#14 Updated by Pascal Obry 12 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Good! Thanks for the feedback. Closing then.

For the record, fixed in: 3803936faba56bce3dc6b511dd2c3ee852101785

#15 Updated by Pascal Obry 12 months ago

  • Target version deleted (2.6.1)

Also available in: Atom PDF

Go to top