Project

General

Profile

Bug #12551

New instance of color balance is created in RGBL instead of HSL

Added by Marco Carrarini 3 months ago. Updated 3 months ago.

Status:
Confirmed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
01/15/2019
Due date:
% Done:

10%

Affected Version:
git stable branch
System:
Windows
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Hi,
I want to report a minor issue in the interface of the new color balance module.
Steps to reproduce:
1) create a new instance of the color balance module
2) expected behaviour: the new instance is created with the same mode (HSL or RGBL) of the first module
3) observed behaviour: the new instance is always created with RGBL. You have force reset the mode to get HSL

I am on DT 2.6.0 on Windows 10

Cheers,
Marco

History

#1 Updated by Roman Lebedev 3 months ago

total hijacking: some similar weird behaviour with the tone curve type happening in tone curve module, why does it default to not lab, it is the lab tone curve.

#2 Updated by Pascal Obry 3 months ago

  • Target version changed from 2.6.0 to Future

AFAIK, this is a old very old bug/behavior that never get tracked down.

#3 Updated by Aurélien PIERRE 3 months ago

Roman Lebedev wrote:

total hijacking: some similar weird behaviour with the tone curve type happening in tone curve module, why does it default to not lab, it is the lab tone curve.

What do you mean it's the lab tone curve ? The tone curve has only 3 curves stored : L, a, b. The L curve is actually used for RGB and XYZ modes too, so it's the same curve applied in different colorspaces.

As for the colorbalance, I have to rewrite the GUI using GTK stacks, put the sliders in stacks, and enable full stacks. Currently, sliders are enabled/disabled separately, and for some reason, they are not set properly when a new instance is created.

Or maybe the new instance creation does not trigger the necessary GUI events. Anyway, it's on the bottom of my to-do list.

#4 Updated by Aurélien PIERRE 3 months ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

Also available in: Atom PDF