Project

General

Profile

Feature #12520

Collect images by darkroom module used

Added by Martin Scharnke 11 months ago. Updated 11 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Lighttable
Target version:
-
Start date:
01/01/2019
Due date:
% Done:

0%

Estimated time:
Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

2.6 brought about a magnificent improvement in collection filtering ability.
I would think that an incremental enhancement to this filtering would be to select for darkroom module used. At the moment the only possibility is to either use the history filter, or, equiavelently, use the tag filter for darktable|altered. When I have many (> 20) images of a subject, I would be glad to be able to filter by an arbitrarily chosen darkroom module in the history. For example, all images I have applied crop/rotate to, or tone mapping to, or that I have denoised.

I'm prepared to put some work into this, but I'd need some hand-holding: my coding in C goes back to my first university days: 1988-1991. I can pull the entire source repository, but I don't know where to start with locating the collect images filtering code, or how to extract the database information for history for each image in the currnt selection.

History

#1 Updated by Haribo M 11 months ago

Great idea.
I was asking very similar a couple of month ago using the darktable-user mailing list.
https://www.mail-archive.com/darktable-user@lists.darktable.org/msg05942.html
Hope you can make it happen this time.
Thanks in advance.

#2 Updated by Pascal Obry 11 months ago

I think this is a good idea. It should not be too difficult. I'm ready to review. As an example you can review the following commit:

https://github.com/darktable-org/darktable/commit/d18bded07337b135dd8b549f8f08fa5c853b7f41

This should give you an overview of what is needed. And the code around these changes are for the other collect criteria.

Also available in: Atom PDF

Go to top