Project

General

Profile

Bug #12448

duplicate manager: segfault when trashing the first clone

Added by Matthieu Moy 3 months ago. Updated 3 months ago.

Status:
Fixed
Priority:
Critical
Assignee:
Category:
Darkroom
Target version:
Start date:
12/08/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Seems reproducible.

Steps to reproduce:

  • Open an image
  • Make a clone
  • In the duplicate manager, click the cross (x) to trash the first clone (only the first triggers this)
  • Click "yes" in the dialog to accept trashing the clone

Behavior:

Segfault.

Backtrace attached, if it helps.

stair-vertical.png (7.44 KB) Matthieu Moy, 12/08/2018 12:56 PM

gdb.txt Magnifier - This time, the backtrace ;-) (113 KB) Matthieu Moy, 12/08/2018 03:55 PM

new-gdb.txt Magnifier (170 KB) Matthieu Moy, 12/08/2018 05:06 PM

Associated revisions

Revision 68f9b0d4
Added by Pascal Obry 3 months ago

duplicate: disable deleting the last duplicate.

We can't leave the darktable opened without a selected picture. And it
should fix the bug #12448.

History

#1 Updated by Pascal Obry 3 months ago

  • Category set to Darkroom
  • Assignee set to Pascal Obry
  • Priority changed from Low to Critical
  • Target version set to 2.6.0

Wrong file attached :)

#2 Updated by Pascal Obry 3 months ago

I was not able to reproduce the crash. But I was able to remove both the clone and the original, leaving the darkroom with an empty black image. That's just wrong. I think we should disable deleting the first image or at least the last one.

#3 Updated by Pascal Obry 3 months ago

If you can check https://github.com/darktable-org/darktable/pull/1884 it will be great.

#4 Updated by Matthieu Moy 3 months ago

Wrong file indeed, this one is the backtrace.

#5 Updated by Matthieu Moy 3 months ago

FYI, I can't reproduce if I delete my library.db, but it segfaults reproducibly with my old library.db, including for new images (i.e. I can import an image darktable had never seen before, duplicate, trash the first duplicate and get a segfault). Surprising.

This is without PR #1884 for now.

#6 Updated by Matthieu Moy 3 months ago

New backtrace attached.

#7 Updated by Pascal Obry 3 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Fixed in commit f01d1303.

Also available in: Atom PDF