Project

General

Profile

Bug #12445

Incorrect view for second color balance iop instance

Added by Masoud M 6 months ago. Updated 3 months ago.

Status:
Confirmed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
12/07/2018
Due date:
% Done:

10%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

When a new instance of the color balance iop is created, it shows color control sliders in "both" mode while the "color control sliders" is set to "HSL"

History

#1 Updated by Aurélien PIERRE 6 months ago

  • % Done changed from 0 to 10
  • Status changed from New to Confirmed

I know, I have never been able to find out why.

#2 Updated by rawfiner - 6 months ago

I had a similar problem with denoise profiled.
Both wavelet and nlmeans sliders were appearing when creating a new instance, no matter what I did with gtk_widget_set_visible...

I still don't know why there was this behavior...
I finally managed to solve it using a gtk stack.
See this commit:
https://github.com/darktable-org/darktable/commit/6ca618d276cf9cb731758ca29a68fc20bb3507d2
I guess you could do something similar here.

#3 Updated by Pascal Obry 6 months ago

When a new instance is created I think gui_reset() should be called. But that's not the case. I'll work on that.

#4 Updated by Pascal Obry 3 months ago

Mister y solved :) The color control slider is not saved in parameters so each time a new instance (or you restart dt) the slider is set back to the first combo entry.

#5 Updated by Pascal Obry 3 months ago

This is indeed a GUI option and so not part of params, not really a bug. But if we want to fix it we need to add the control mode into the parameters.

Also available in: Atom PDF