Project

General

Profile

Bug #12442

Non-smooth and weird behavior with filmic

Added by Matthieu Moy 6 months ago. Updated 6 months ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
Darkroom
Target version:
Start date:
12/04/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
all
bitness:
64-bit
hardware architecture:
amd64/x86

Description

A weird and probably unexpected behavior of filmic:

With middle grey = 15%
white = 3.70 EV
black = -3.70 EV

I get a decent result. Now, if I change the black to 3.71 (i.e. only a very small change), I get a totally different curve and image.

On this image, the "auto tune levels" was giving me

With middle grey = 15%
white = 3.70 EV
black = -2.21 EV

The black was obviously too close to 0, but moving it further in the negatives, the image became worse (for a while, and it gets back to a good results after the weird threshold effect above).

black-3.70.jpg - Black = -3.70, smooth curve (80.3 KB) Matthieu Moy, 12/04/2018 11:03 PM

black-3.71.jpg - Black = -3.71, totally different curve and image (88.7 KB) Matthieu Moy, 12/04/2018 11:03 PM

History

#1 Updated by Aurélien PIERRE 6 months ago

this is related to the way nodes are sanitized (probably too conservative for users to see where the mistakes come from), so I have removed some checks on the nodes position in my last PR, hoping the errors will be more understandable than wrong parameters half-corrected silently.

Another proof that trying to take care back-end of the errors for the "stupid" user actually creates more problems than just displaying a blocking error with some meaningful output… [or "when you try to build software that prevents user from doing stupid things, you end-up building stupid software"]

#2 Updated by Aurélien PIERRE 6 months ago

  • System changed from Ubuntu to all
  • % Done changed from 0 to 70
  • Target version set to 2.6.0
  • Status changed from New to Patch attached

#3 Updated by Aurélien PIERRE 6 months ago

  • % Done changed from 70 to 100
  • Status changed from Patch attached to Fixed

Also available in: Atom PDF