Project

General

Profile

Bug #12427

liquify: crash when drawing a shape

Added by Matthieu Moy about 2 months ago. Updated about 2 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
Darkroom
Target version:
Start date:
11/29/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Since the fix for #12426, I get a crash whenever a draw a shape. Seemed reproducible, but I can't reproduce anymore after rm -fr ~/.config/darktable.

Before that, I got the crash simply by:

- Open liquify
- activate the point tool
- click on the image

Backtraces attached (probably equivalent to each other, but I've got 3, so I'm attaching them all).

If you can understand what's going on, perfect. If not, since I can't reproduce anymore, I'm fine with closing the bug.

darktable_bt_X5WRTZ.txt Magnifier (103 KB) Matthieu Moy, 11/29/2018 07:07 PM

darktable_bt_S318SZ.txt Magnifier (103 KB) Matthieu Moy, 11/29/2018 07:07 PM

darktable_bt_9PYMTZ.txt Magnifier (104 KB) Matthieu Moy, 11/29/2018 07:07 PM

Associated revisions

Revision 7888fb92
Added by Pascal Obry about 2 months ago

liquify: do some sanity check on pref values.

Try to fix #12427.

Revision 98e1b10b
Added by Pascal Obry about 2 months ago

liquify: also check for too big prefs.

Try to fix #12427.

History

#1 Updated by Pascal Obry about 2 months ago

Hum... could be a wrong value in the preferences. I'll make sure all of them are > 0.

#2 Updated by Matthieu Moy about 2 months ago

Good idea to sanitize the preferences on reading. It's a real pain for the user when a mis-behavior results in a preference file which makes dt keep crashing even after reboot.

#3 Updated by Pascal Obry about 2 months ago

  • Assignee set to Pascal Obry
  • % Done changed from 0 to 100
  • Category set to Darkroom
  • Status changed from New to Fixed
  • Target version set to 2.6.0

See my tentative fix.

Also available in: Atom PDF