Project

General

Profile

Bug #12426

liquify: weird behavior when clicking several buttons in a row

Added by Matthieu Moy 10 months ago. Updated 10 months ago.

Status:
Fixed
Priority:
Medium
Assignee:
Category:
Darkroom
Target version:
Start date:
11/28/2018
Due date:
% Done:

100%

Estimated time:
Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Steps to reproduce:

- Open the liquify module
- Click "point tool"
- Click "line tool"

Expected:

The point tool is deactivated, the line tool is activated instead.

Actual:

The point tool icon is still shown as activated, the line tool is, too. However, none of the tool is really active, one can't draw anything one the image while in this state.

Trying to fix the situation by disabling and re-enabling the module only makes things worse: I got to a state where I could not re-activate any tool without restarting dt.

I guess we need something similar to the dt_iop_color_picker_reset() we have to disable a color picker when we pick another one.

Associated revisions

Revision aec9ebf5 (diff)
Added by Pascal Obry 10 months ago

liquify: fix tool buttons handling.

When a line or curve is not yet started it is possible to change the
tool by clicking on the corresponding button. when a line or curve
is started it needs to be finished before selecting about tool.

This fixes bad behavior and crashes and is a nice usability fix.

Fixed #12426.

History

#1 Updated by Pascal Obry 10 months ago

This is a very delicate part as one of the node is active in a temp section to be able to display it. So I guess we need to remove it and re-create a new one for the new selected tool. I didn't look at the actual code and don't remember all details but I suppose today we recreate a new temp node without removing the current one which is probably still in the array of node...

#2 Updated by Matthieu Moy 10 months ago

There's already code to disable a tool (hence remove the temp node), so isn't it as simple as calling the code to disable the previous tool and then enable the new one?

#3 Updated by Pascal Obry 10 months ago

Maybe, try this :)

#4 Updated by Matthieu Moy 10 months ago

I'm out of dt time budget for a while, so don't hold your breath if you expect me to do the fix unfortunately :-\.

#5 Updated by Pascal Obry 10 months ago

  • Target version set to 2.6.0
  • Priority changed from Low to Medium
  • Assignee set to Pascal Obry
  • Category set to Darkroom

Ok, fine I'll try to fix that.

#6 Updated by Pascal Obry 10 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

Should be fixed now.

Also available in: Atom PDF

Go to top