Project

General

Profile

Bug #12425

crash in liquify: src/iop/liquify.c:801: compute_round_stamp_extent: Assertion `iradius > 0' failed.

Added by Matthieu Moy 4 months ago. Updated 4 months ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
11/27/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

I get the following crash in liquify

darktable: /home/moy/local/usr/src/darktable-dev/src/iop/liquify.c:801: compute_round_stamp_extent: Assertion `iradius > 0' failed.
Aborted (core dumped)

Steps to reproduce:

- open liquify
- select "point tool: draw points"
- mouse over the image, wheel-mouse up to reduce the radius

Expected:

- the radius is reduced, slightly

Actual:

- the radius is changed to 0 immediately (the yellow disk disappears at the first move of the wheel)
- turning the mouse wheel the other way around doesn't restore the yellow disk
- clicking to add a point yields the assertion failure above.

Associated revisions

Revision 951bd8c5
Added by Matthieu Moy 4 months ago

liquify: fix mouse wheel on first launch

On first launch, CONF_RADIUS was not set in the configuration, but the
configuration was used on mouse scroll, resulting in a 0-radius point.
Save the default to the configuration when the default is used.

Fixes #12425.

History

#1 Updated by Pascal Obry 4 months ago

I had that one time and was never able to reproduce. I just tried and can't reproduce... Any idea to what could trigger this?

#2 Updated by Matthieu Moy 4 months ago

Weird: it was 100% reproducible on the machine on which I did the bug report, and now, on another machine, I get a different behavior.

I can reproduce the "yellow disk disappears on mouse wheel" doing rm -fr ~/.config/darktable/ before launching dt. I'm not getting the assertion failure after that, but it's probably the same issue with different symptoms.

I suspected stg like uninitialized variable, but the valgrind warnings I get seems unrelated (I'll still post a straightforward PR soon to fix them).

#3 Updated by Matthieu Moy 4 months ago

Hmm, probably not completely unrelated actually:

https://github.com/darktable-org/darktable/pull/1855

But it seems to be a consequence of the problem, not the cause.

#4 Updated by Anonymous 4 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Fixed

#5 Updated by Roman Lebedev 4 months ago

  • Target version set to 2.6.0

Also available in: Atom PDF