colorbalance.c:241: add_preset: Assertion `len == sizeof(dt_iop_colorbalance_params_t)' failed.
Everything is in the title ;-). I get the assertion failure reproducibly when starting dt.
#2 Updated by Aurélien PIERRE 4 months ago
I think I might remove these presets, they are too difficult to maintain. The problem is, shipping blendops parameters with them, you have to harcode the blobs from the XMP parameters and trigger the XMP parser to interpret them, but as soon as a new blendop version is pushed, they become invalid.
#3 Updated by Matthieu Moy 4 months ago
Oops, went too far in bisection. This one should be the right one:
commit 2d37df02ecdce9f58269eef57d319d777b830f29 Author: Aurélien PIERRE <email@example.com> Date: Sun Nov 25 05:28:08 2018 -0500 add an output saturation correction to comply with ASC guidelines
#7 Updated by Pascal Obry 4 months ago
assert(len == sizeof(dt_iop_colorbalance_params_t));
This is bogus as it compares the len (size of the params as inserted into the source code) and the current size of the struct.
But len here is the length of the version 2 of colorbalance and not the last version 3.
I'll remove the assert here and in denoiseprofile.