Project

General

Profile

Bug #12421

colorbalance.c:241: add_preset: Assertion `len == sizeof(dt_iop_colorbalance_params_t)' failed.

Added by Matthieu Moy 6 months ago. Updated 6 months ago.

Status:
Fixed
Priority:
Low
Assignee:
Category:
-
Target version:
Start date:
11/25/2018
Due date:
% Done:

100%

Affected Version:
git master branch
System:
Ubuntu
bitness:
64-bit
hardware architecture:
amd64/x86

Description

Everything is in the title ;-). I get the assertion failure reproducibly when starting dt.

History

#1 Updated by Matthieu Moy 6 months ago

Bisects down to

commit e20c711067a7a1e5d39e970f851f49589a734769 (refs/bisect/bad)
Author: rawfiner <rawfiner@gmail.com>
Date:   Mon Oct 15 21:04:05 2018 +0200

    DenoiseProfile GUI: add frequency curves

#2 Updated by Aurélien PIERRE 6 months ago

I think I might remove these presets, they are too difficult to maintain. The problem is, shipping blendops parameters with them, you have to harcode the blobs from the XMP parameters and trigger the XMP parser to interpret them, but as soon as a new blendop version is pushed, they become invalid.

#3 Updated by Matthieu Moy 6 months ago

Oops, went too far in bisection. This one should be the right one:

commit 2d37df02ecdce9f58269eef57d319d777b830f29
Author: Aurélien PIERRE <aurelien@aurelienpierre.com>
Date:   Sun Nov 25 05:28:08 2018 -0500

    add an output saturation correction to comply with ASC guidelines

#4 Updated by Aurélien PIERRE 6 months ago

Yes, I know. :-)

#5 Updated by Pascal Obry 6 months ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100
  • Assignee set to Pascal Obry

Fixed.

#6 Updated by Matthieu Moy 6 months ago

I'm still getting the error (after deleting my .config/darktable directory).

darktable: .../darktable/src/iop/colorbalance.c:242: add_preset: Assertion `len == sizeof(dt_iop_colorbalance_params_t)' failed.

#7 Updated by Pascal Obry 6 months ago

Indeed:
assert(len == sizeof(dt_iop_colorbalance_params_t));

This is bogus as it compares the len (size of the params as inserted into the source code) and the current size of the struct.

But len here is the length of the version 2 of colorbalance and not the last version 3.

I'll remove the assert here and in denoiseprofile.

#8 Updated by Roman Lebedev 6 months ago

  • Target version set to 2.6.0

Also available in: Atom PDF